Re: [Qemu-devel] [PATCH v7 79/80] qemu-doc: Amend MIPS-related items

[Thomas Huth <thuth@redhat.com>]

On 08/06/2018 07:00 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
> 
> Amend MIPS-related items in qemu-doc.texi
> 
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> Signed-off-by: Stefan Markovic <smarkovic@wavecomp.com>

As far as I've understood the SoB process, your SoB should go last if
you're the last person who has touched this patch, Alexander. I think it
would also be good if you'd use the same e-mail for sending patches as
you used for the SoB in the patches (you sent with rt-rk.com, but used
wavecomp.com in the SoB).

> ---
>  qemu-doc.texi | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index abfd2db..8ea6bfa 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -2693,8 +2693,17 @@ The binary format is detected automatically.
>  @command{qemu-microblaze} TODO.
>  
>  @cindex user mode (MIPS)
> -@command{qemu-mips} TODO.
> -@command{qemu-mipsel} TODO.
> +@command{qemu-mips} executes 32-bit big endian MIPS binaries (MIPS O32 ABI).
> +
> +@command{qemu-mipsel} executes 32-bit little endian MIPS binaries (MIPS O32 ABI).
> +
> +@command{qemu-mips64} executes 64-bit big endian MIPS binaries (MIPS O64 ABI).
> +
> +@command{qemu-mips64el} executes 64-bit little endian MIPS binaries (MIPS O64 ABI).
> +
> +@command{qemu-mipsn32} executes 32-bit big endian MIPS binaries (MIPS N32 ABI).
> +
> +@command{qemu-mipsn32el} executes 32-bit little endian MIPS binaries (MIPS N32 ABI).

Looks reasonable to me.

Reviewed-by: Thomas Huth <thuth@redhat.com>