From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Max Reitz" <mreitz@redhat.com>
Subject: Re: Auditing QEMU to replace NULL with &error_abort
Date: Wed, 23 Jun 2021 11:01:30 -0400 [thread overview]
Message-ID: <c3fca4e4-52b6-15f0-5de4-7a1109cc3bc3@redhat.com> (raw)
In-Reply-To: <87k0mk4vyg.fsf@dusky.pond.sub.org>
On 6/23/21 8:16 AM, Markus Armbruster wrote:
> Nevertheless, I'm reluctant to add more differeneces. That's not a
> "no". It's a "you need to make a compelling case".
I'm not sure it's my case to make; I believe you are the authority in
this matter so the work should be defined in terms of what you are
prepared to accept.
I'm not sure there's a better argument for &error_ignore beyond "It's
easy to audit", but I find that to be a compelling one especially where
new contributors are concerned.
If we still wanted to move back to glib (which seems unlikely) replacing
&error_ignore by NULL seems like a trivial thing to do. Your call.
--js
next prev parent reply other threads:[~2021-06-23 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 15:20 Auditing QEMU to replace NULL with &error_abort John Snow
2021-06-23 12:16 ` Markus Armbruster
2021-06-23 15:01 ` John Snow [this message]
2021-06-23 15:08 ` Daniel P. Berrangé
2021-06-23 15:31 ` Marc-André Lureau
2021-06-23 15:39 ` Daniel P. Berrangé
2021-06-23 17:24 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3fca4e4-52b6-15f0-5de4-7a1109cc3bc3@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).