From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D19EEE0200 for ; Wed, 13 Sep 2023 18:46:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgUsL-0001Yp-MZ; Wed, 13 Sep 2023 14:46:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgUs8-0001WX-I8 for qemu-devel@nongnu.org; Wed, 13 Sep 2023 14:46:06 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgUs5-0002Rx-NS for qemu-devel@nongnu.org; Wed, 13 Sep 2023 14:45:56 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 3FF66E0005; Wed, 13 Sep 2023 18:45:46 +0000 (UTC) Message-ID: Date: Wed, 13 Sep 2023 20:46:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: i.maximets@ovn.org, Stefan Hajnoczi , qemu-devel@nongnu.org Content-Language: en-US To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Jason Wang References: <20230908064507.14596-1-jasowang@redhat.com> <1186b0b7-7dc5-d926-e6ff-ba3da2238b9c@ovn.org> <4508010f-12e8-8565-d091-e8c68ae0493e@ovn.org> <755f9eb1-d97f-a359-3050-f3289374655b@ovn.org> From: Ilya Maximets Subject: Re: [PULL 00/17] Net patches In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: i.maximets@ovn.org Received-SPF: pass client-ip=217.70.183.196; envelope-from=i.maximets@ovn.org; helo=relay4-d.mail.gandi.net X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-1.473, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 9/8/23 16:15, Daniel P. BerrangĂ© wrote: > On Fri, Sep 08, 2023 at 04:06:35PM +0200, Ilya Maximets wrote: >> On 9/8/23 14:15, Daniel P. BerrangĂ© wrote: >>> On Fri, Sep 08, 2023 at 02:00:47PM +0200, Ilya Maximets wrote: >>>> On 9/8/23 13:49, Daniel P. BerrangĂ© wrote: >>>>> On Fri, Sep 08, 2023 at 01:34:54PM +0200, Ilya Maximets wrote: >>>>>> On 9/8/23 13:19, Stefan Hajnoczi wrote: >>>>>>> Hi Ilya and Jason, >>>>>>> There is a CI failure related to a missing Debian libxdp-dev package: >>>>>>> https://gitlab.com/qemu-project/qemu/-/jobs/5046139967 >>>>>>> >>>>>>> I think the issue is that the debian-amd64 container image that QEMU >>>>>>> uses for testing is based on Debian 11 ("bullseye" aka "oldstable") >>>>>>> and libxdp is not available on that release: >>>>>>> https://packages.debian.org/search?keywords=libxdp&searchon=names&suite=oldstable§ion=all >>>>>> >>>>>> Hmm. Sorry about that. >>>>>> >>>>>>> >>>>>>> If we need to support Debian 11 CI then either XDP could be disabled >>>>>>> for that distro or libxdp could be compiled from source. >>>>>> >>>>>> I'd suggest we just remove the attempt to install the package for now, >>>>>> building libxdp from sources may be a little painful to maintain. >>>>>> >>>>>> Can be re-added later once distributions with libxdp 1.4+ will be more >>>>>> widely available, i.e. when fedora dockerfile will be updated to 39, >>>>>> for example. That should be soon-ish, right? >>>>> >>>>> If you follow the process in docs/devel/testing.rst for adding >>>>> libxdp in libvirt-ci, then lcitool will "do the right thing" >>>>> when we move the auto-generated dockerfiles to new distro versions. >>>> >>>> Thanks! I'll prepare changes for libvirt-ci. >>>> >>>> In the meantime, none of the currently tested images will have a required >>>> version of libxdp anyway, so I'm suggesting to just drop this one dockerfile >>>> modification from the patch. What do you think? >>> >>> Sure, if none of the distros have it, then lcitool won't emit the >>> dockerfile changes until we update the inherited distro version. >>> So it is sufficient to just update libvirt-ci.git with the mappings.yml >>> info for libxdp, and add 'libxdp' to the tests/lcitool/projects/qemu.yml >>> file in qemu.git. It will then 'just work' when someone updates the >>> distro versions later. >> >> I posted an MR for libvirt-ci adding libxdp: >> https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/429 >> >> Please, take a look. >> >> The docs say that CI will try to build containers with the MR changes, >> but I don't think anything except sanity checks is actually tested on MR. >> Sorry if I missed something, never used GitLab pipelines before. > > No, that's our fault - we've broken the CI and your change alerted > me to that fact :-) > >> Note that with this update we will be installing older version of libxdp >> in many containers, even though they will not be used by QEMU, unless >> they are newer than 1.4.0. > > No problem, as it means QEMU CI will demonstrate the the meson.build > change is ignoring the outdatd libxdp. > >> tests/lcitool/projects/qemu.yml in qemu.git cannot be updated without >> updating a submodule after the MR merge. > > Yep. Since all the required changes went into libvirt-ci project, I posted an updated patch set named: '[PATCH v4 0/2] net: add initial support for AF_XDP network backend' Please, take a look. This should fix the CI issues, though I'm not sure how to run QEMU gitlab pipelines myself, so I didn't actually test all the images. Sent as a patch set because the libvirt-ci submodule bump brings in a few unrelated changes. So, I split that into a separate patch. Best regards, Ilya Maximets.