qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>,
	Christophe Lyon <christophe.lyon@linaro.org>
Subject: Re: [PATCH-for-8.1] linux-user/arm: Do not allocate a commpage at all for M-profile CPUs
Date: Fri, 14 Jul 2023 07:23:18 +0100	[thread overview]
Message-ID: <c412a56e-0049-f7a6-19b1-12dcfcf0bab4@linaro.org> (raw)
In-Reply-To: <20230711153408.68389-1-philmd@linaro.org>

On 7/11/23 16:34, Philippe Mathieu-Daudé wrote:
> Since commit fbd3c4cff6 ("linux-user/arm: Mark the commpage
> executable") executing bare-metal (linked with rdimon.specs)
> cortex-M code fails as:
> 
>    $ qemu-arm -cpu cortex-m3 ~/hello.exe.m3
>    qemu-arm: ../../accel/tcg/user-exec.c:492: page_set_flags: Assertion `last <= GUEST_ADDR_MAX' failed.
>    Aborted (core dumped)
> 
> Commit 4f5c67f8df ("linux-user/arm: Take more care allocating
> commpage") already took care of not allocating a commpage for
> M-profile CPUs, however it had to be reverted as commit 6cda41daa2.
> 
> Re-introduce the M-profile fix from commit 4f5c67f8df.
> 
> Fixes: fbd3c4cff6 ("linux-user/arm: Mark the commpage executable")
> Resolves:https://gitlab.com/qemu-project/qemu/-/issues/1755
> Reported-by: Christophe Lyon<christophe.lyon@linaro.org>
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   linux-user/elfload.c | 21 +++++++++++++++++----
>   1 file changed, 17 insertions(+), 4 deletions(-)

Queued to tcg+linux-user.

r~


      parent reply	other threads:[~2023-07-14  6:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-11 15:34 [PATCH-for-8.1] linux-user/arm: Do not allocate a commpage at all for M-profile CPUs Philippe Mathieu-Daudé
2023-07-11 21:08 ` Richard Henderson
2023-07-12 13:39 ` Anton Johansson via
2023-07-14  6:23 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c412a56e-0049-f7a6-19b1-12dcfcf0bab4@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=christophe.lyon@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).