From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7B17C05027 for ; Fri, 20 Jan 2023 10:28:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIoby-0005v2-Ue; Fri, 20 Jan 2023 05:27:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIobw-0005u2-VO for qemu-devel@nongnu.org; Fri, 20 Jan 2023 05:27:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIobv-0001Wv-9G for qemu-devel@nongnu.org; Fri, 20 Jan 2023 05:27:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674210422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rCVypidnFx4JW/rDZPAfoj7ZI+PT0BWLXal/Pm0vWNM=; b=RBK34XSrD+QLd24ryUY0ZcGwHnX9mRyt8loWTBkSTl+QL9twIo51cXgggnLPdOCCQp+5wD N/T3UTyPX9Y0+H9cFDtV8THycbyDYctiOoqTDJ5OGt/H4eJIb+4HB+sKHOYCnHVdPok9rh /Geo+iXsCqFhmA3bVCKvLt/1PqnIfhc= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-611-RXIwFJ8yO524xOFNdV4oYg-1; Fri, 20 Jan 2023 05:27:01 -0500 X-MC-Unique: RXIwFJ8yO524xOFNdV4oYg-1 Received: by mail-qk1-f200.google.com with SMTP id bq15-20020a05620a468f00b00706ae242abcso3194930qkb.7 for ; Fri, 20 Jan 2023 02:27:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rCVypidnFx4JW/rDZPAfoj7ZI+PT0BWLXal/Pm0vWNM=; b=YVoS3s8CSTfk6T80Gk8K4uHlm02o2PsBB1fmZ4QbTywxSpwjLSO90icC6AK2MpMM82 t5mQ8ZNg7PE8BxN0PQNxb1yv768pSc22QEIxFRFhOEE/Tabu3kwc5ASZqeQPu1HASgDR 1p7nYbo/KGmnKwAV5kDHKSfEeOPHUXPriZhgEEjdOZsmC4xQz1gxMmCO/kg8QgsL7WPv ir/D5crIQAFaTbfW99wtfkiJL+c1DHRu/bFYagqH491BRMFEJ3/kEAekl0gLXM8LX9D/ 2kyTciy79HAoTVIKCcGxqn+qRkpRQzyHK2PskCeGzA2ydp10tY7r3Vl8WgqXicGAoxJU UWSQ== X-Gm-Message-State: AFqh2krNlvW8wf8PCbNxBrlnL43Bq8thb5QpIWkOeo1PNPD+YERTvTN3 WB+GO/sZfIsQYGAquAQbRzCDbh3IMT0cofPbGcKBlq1sOPM08pkxINgizir6Qc9nBMOniQ6kiV/ ld60s6/8hLRD6ca8= X-Received: by 2002:ac8:5444:0:b0:3ab:af8e:64e6 with SMTP id d4-20020ac85444000000b003abaf8e64e6mr16443128qtq.67.1674210420519; Fri, 20 Jan 2023 02:27:00 -0800 (PST) X-Google-Smtp-Source: AMrXdXttwxqa28U1p4sL4dGUzzQjuk4l/NzUng3MRDfYeGlcE1436ks/wu/OzJsaf65rmJskro5YZQ== X-Received: by 2002:ac8:5444:0:b0:3ab:af8e:64e6 with SMTP id d4-20020ac85444000000b003abaf8e64e6mr16443107qtq.67.1674210420281; Fri, 20 Jan 2023 02:27:00 -0800 (PST) Received: from [192.168.0.2] (ip-109-43-177-118.web.vodafone.de. [109.43.177.118]) by smtp.gmail.com with ESMTPSA id q44-20020a05620a2a6c00b006fc9fe67e34sm11812905qkp.81.2023.01.20.02.26.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Jan 2023 02:26:58 -0800 (PST) Message-ID: Date: Fri, 20 Jan 2023 11:26:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [RFC PATCH 6/8] tests/qtest/libqtest: Allow checking for HVF accelerator Content-Language: en-US From: Thomas Huth To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , Laurent Vivier , Fabiano Rosas , Juan Quintela , "Dr. David Alan Gilbert" , qemu-arm@nongnu.org, Markus Armbruster , Igor Mammedov References: <20230119100537.5114-1-philmd@linaro.org> <20230119100537.5114-7-philmd@linaro.org> <147a979d-2d16-4ad3-4330-3e8187f88a2e@redhat.com> In-Reply-To: <147a979d-2d16-4ad3-4330-3e8187f88a2e@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.094, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 19/01/2023 13.05, Thomas Huth wrote: > On 19/01/2023 12.30, Philippe Mathieu-Daudé wrote: >> On 19/1/23 12:24, Thomas Huth wrote: >>> On 19/01/2023 11.05, Philippe Mathieu-Daudé wrote: >>>> Signed-off-by: Philippe Mathieu-Daudé >>>> --- >>>> RFC: CONFIG_HVF is poisoned. >>>> >>>> We could pass host config definitions to qtest using: >>>> >>>>    diff --git a/meson.build b/meson.build >>>>    @@ -2547,6 +2547,7 @@ foreach target : target_dirs >>>> >>>>       accel_kconfig = [] >>>>       foreach sym: accelerators >>>>    +    config_host_data.set(sym + '_QTEST', '') >>>>         if sym == 'CONFIG_TCG' or target in accelerator_targets.get(sym, >>>> []) >>>>           config_target += { sym: 'y' } >>>>           config_all += { sym: 'y' } >>>> >>>> Then test for CONFIG_HVF_QTEST ... >>> >>> I don't think that would really work well. The qtests are build once for >>> all targets, and HVF is only available in the target that matches the >>> host architecture. It's poisoned on purpose. >>> >>> The TCG accelerator is special, since we have it in either none or in all >>> targets, that's why we can use CONFIG_TCG there. >>> >>> The kvm part is also rather a hack... we should maybe rather additionally >>> use the "query-kvm" QAPI command to check whether it is really available...? >>> >>> To fix this properly for HVF, I think you'd need a way to query the >>> available accelerators via QMP, too... Hmmm, weren't there some patches >>> for something like that in the past ... can't remember right now ... >> >> https://lore.kernel.org/qemu-devel/20210505125806.1263441-3-philmd@redhat.com/ >> :( > > Ah, right, and we ended up with the competing patch from Igor since we could > not quite settle on the QAPI extensions? > > Hmm, what happens if you execute "query-qmp-schema" on a HVF-enabled host > these days? Is there a "hvf"-related entry somewhere in the response? Alternative idea: execute QEMU once with "-accel help" via g_spawn_command_line_sync() or g_spawn_sync() once and look for the accelerator in the standard output. Thomas