From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE61C433FE for ; Wed, 15 Sep 2021 07:06:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB6606121F for ; Wed, 15 Sep 2021 07:06:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB6606121F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQOzd-00068J-1y for qemu-devel@archiver.kernel.org; Wed, 15 Sep 2021 03:06:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQOxx-0004ay-FT; Wed, 15 Sep 2021 03:04:21 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:40696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQOxt-0003lC-Ou; Wed, 15 Sep 2021 03:04:21 -0400 Received: by mail-wr1-x435.google.com with SMTP id q26so2140170wrc.7; Wed, 15 Sep 2021 00:04:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XQsK2tVvUIfERCk7xsCI4Ejtq4oM6ZnZ6pFRx/4L4iw=; b=Z6hxxKBQ73xZWGdj1a876+xRkPLxPmzjy0Q4aBJ3UyjIUVupD87cCa3xoXNfm+aEIf kbZAs2jQV1ocYVlNN7IZsQHZ50x+juMtL/Qz4Vy/wz7VD3Exc5eOWcYdggXM7VSS6Jx4 DY3Jw5jnGJ/23Rpq7BWCRj/wl+RqilDldBWFXy+5/o37GHl6CG3T4qEeinMz0P53iESP mWrt0wzs0PeYKGWjsVDkSELIlXd/xGswToR28P2l5uJizOf31JCFGSOk8JfWaQfHnYx9 O6ScS76334uNBno+0MLsEC5VOTHhWPABNBjlsYluFgjn80NOCV34vgbTnsl1+wXICj53 jctQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XQsK2tVvUIfERCk7xsCI4Ejtq4oM6ZnZ6pFRx/4L4iw=; b=o57wdx1I1fv/KbNMuBWiKzJMYfGC7jzBxZK8G25/x0EFqOBLvDOV7v70lqmaN23Cu/ P/fOiN7FNGnVdZf6/fRcSsUAS1+2Op24hmir9QdxujWO/3NN7odc7Y6Y+U9/bN1UWpk7 Myt2VxtLLFAa5FaBIYbt45M0dDAJTItYtP3j22giZK+m0uSGc27u2h5MulHZAKH4YK5u f19+38ok50L522MmsKeV3OJOmFzY7pES9R+OaqFYJ0c+7nBFlV/VWKZtLPxfjrflapot CbRRwT2+6jqJX9/e9WP4X73AWURGuBwu0JGpeX4NQtrnWN721c+z2mFwrUL88gYT4oYk hfEA== X-Gm-Message-State: AOAM532MNuSmBibolnU7P3JPAQ3XrQUqkjMUXPmVZSyqA8R41maNF6YM oKVj+Yc4wZH5P+hWSsYLAYg= X-Google-Smtp-Source: ABdhPJxl1xRdpU3R0VolQNysf1ZStu3nAmstP7zaSPgWxJUI0BRb8Efwuo+cTOUurEt58v/x5kV2Vg== X-Received: by 2002:adf:fc0e:: with SMTP id i14mr3129525wrr.173.1631689454892; Wed, 15 Sep 2021 00:04:14 -0700 (PDT) Received: from [192.168.1.36] (14.red-83-35-25.dynamicip.rima-tde.net. [83.35.25.14]) by smtp.gmail.com with ESMTPSA id y1sm3531747wmq.43.2021.09.15.00.04.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Sep 2021 00:04:14 -0700 (PDT) Subject: Re: [PATCH v2 17/53] target/mips: convert to use format_state instead of dump_state To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-18-berrange@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Wed, 15 Sep 2021 09:04:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210914142042.1655100-18-berrange@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x435.google.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-1.969, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cornelia Huck , David Hildenbrand , Bin Meng , Mark Cave-Ayland , Yuval Shaia , Peter Xu , Max Filippov , Taylor Simpson , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Eric Blake , Marek Vasut , Yoshinori Sato , Markus Armbruster , Halil Pasic , Christian Borntraeger , qemu-ppc@nongnu.org, Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , "Dr. David Alan Gilbert" , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Laurent Vivier , Palmer Dabbelt , Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/mips/cpu.c | 85 +++++++++++++++++++++++++---------------------- > 1 file changed, 45 insertions(+), 40 deletions(-) > > diff --git a/target/mips/cpu.c b/target/mips/cpu.c > index d426918291..9ced90d810 100644 > --- a/target/mips/cpu.c > +++ b/target/mips/cpu.c > @@ -42,76 +42,81 @@ const char regnames[32][3] = { > "t8", "t9", "k0", "k1", "gp", "sp", "s8", "ra", > }; > > -static void fpu_dump_fpr(fpr_t *fpr, FILE *f, bool is_fpu64) > +static void fpu_dump_fpr(fpr_t *fpr, GString *buf, bool is_fpu64) > { > if (is_fpu64) { > - qemu_fprintf(f, "w:%08x d:%016" PRIx64 " fd:%13g fs:%13g psu: %13g\n", > - fpr->w[FP_ENDIAN_IDX], fpr->d, > - (double)fpr->fd, > - (double)fpr->fs[FP_ENDIAN_IDX], > - (double)fpr->fs[!FP_ENDIAN_IDX]); > + g_string_append_printf(buf, "w:%08x d:%016" PRIx64 > + " fd:%13g fs:%13g psu: %13g\n", IIUC QEMU coding style, the 2nd part of the format should be aligned with the first part. (multiple occurrences in this series). Otherwise: Reviewed-by: Philippe Mathieu-Daudé