From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46CC3C433F5 for ; Tue, 18 Jan 2022 18:16:49 +0000 (UTC) Received: from localhost ([::1]:48980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9t2F-00015U-NW for qemu-devel@archiver.kernel.org; Tue, 18 Jan 2022 13:16:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9t04-0008Mi-7F; Tue, 18 Jan 2022 13:14:32 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:28008) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9t02-0006ZH-E3; Tue, 18 Jan 2022 13:14:31 -0500 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 20IH21gB020493; Tue, 18 Jan 2022 18:14:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=OeeIQHqSciwW8HtOkIWIfQsZnXz5o0lCVu5yRMTLSyE=; b=oymmLdS8mgGgX202aInL1EajDhGARWY0Zy+Jd8gEsTYuNC8hA7U+vW32G5ZO2nyAZwlU TQXvkW6QQf+YQWBTtASbXTiqRRmS7WaugMiVZBSHtuRUIiYdbPdRMwdqIjX7KD2msIFb siJxRXwGI4ApB9asDIgaXADyhPdivXvYjzaaFjACxT20mo0UDRodNcx84W2AWHjeU5Yn OTfWO4OmXOuQ7LrpK6eF2LcDuon+4QOX4RNYEWnIZSc80RJ+yXnD2Eqb3Z0JB7YFQJRw yLWIweljJYCaJQepJCNsjAXfVAlYDUa39eDkdOpRWT54/eEJTpkclzBFXfqSsEnb0TtW Rw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3dp1kehugw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Jan 2022 18:14:27 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 20IHlALQ005227; Tue, 18 Jan 2022 18:14:27 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 3dp1kehuga-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Jan 2022 18:14:26 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 20IIDY2Y015506; Tue, 18 Jan 2022 18:14:25 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma01dal.us.ibm.com with ESMTP id 3dknwbmt99-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Jan 2022 18:14:25 +0000 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 20IIEMVR30212398 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Jan 2022 18:14:22 GMT Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BB14C6E054; Tue, 18 Jan 2022 18:14:22 +0000 (GMT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 56F4A6E058; Tue, 18 Jan 2022 18:14:21 +0000 (GMT) Received: from [9.163.19.30] (unknown [9.163.19.30]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 18 Jan 2022 18:14:21 +0000 (GMT) Message-ID: Date: Tue, 18 Jan 2022 13:14:20 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2 4/9] s390x/pci: enable for load/store intepretation Content-Language: en-US To: Thomas Huth , qemu-s390x@nongnu.org References: <20220114203849.243657-1-mjrosato@linux.ibm.com> <20220114203849.243657-5-mjrosato@linux.ibm.com> <9f55cf89-9d58-b1c5-0d97-d0730498b62f@redhat.com> From: Matthew Rosato In-Reply-To: <9f55cf89-9d58-b1c5-0d97-d0730498b62f@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: dqFDtpTBfAeCKNOg7Ab3nqEQL-S9A1hR X-Proofpoint-ORIG-GUID: GU6hwFD1tTh9LEIpVME2YgJrZoKJkF1l X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-18_05,2022-01-18_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 mlxscore=0 impostorscore=0 adultscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2201180109 Received-SPF: pass client-ip=148.163.156.1; envelope-from=mjrosato@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: farman@linux.ibm.com, kvm@vger.kernel.org, pmorel@linux.ibm.com, schnelle@linux.ibm.com, cohuck@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, pasic@linux.ibm.com, alex.williamson@redhat.com, mst@redhat.com, pbonzini@redhat.com, david@redhat.com, borntraeger@linux.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/17/22 10:38 AM, Thomas Huth wrote: > On 14/01/2022 21.38, Matthew Rosato wrote: >> Use the associated vfio feature ioctl to enable interpretation for >> devices >> when requested.  As part of this process, we must use the host function >> handle rather than a QEMU-generated one -- this is provided as part of >> the >> ioctl payload. >> >> Signed-off-by: Matthew Rosato >> --- >>   hw/s390x/s390-pci-bus.c          | 70 +++++++++++++++++++++++++++++++- >>   hw/s390x/s390-pci-inst.c         | 63 +++++++++++++++++++++++++++- >>   hw/s390x/s390-pci-vfio.c         | 52 ++++++++++++++++++++++++ >>   include/hw/s390x/s390-pci-bus.h  |  1 + >>   include/hw/s390x/s390-pci-vfio.h | 15 +++++++ >>   5 files changed, 199 insertions(+), 2 deletions(-) >> >> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c >> index 01b58ebc70..a39ccfee05 100644 >> --- a/hw/s390x/s390-pci-bus.c >> +++ b/hw/s390x/s390-pci-bus.c > ... >> @@ -1360,6 +1427,7 @@ static Property s390_pci_device_properties[] = { >>       DEFINE_PROP_UINT16("uid", S390PCIBusDevice, uid, UID_UNDEFINED), >>       DEFINE_PROP_S390_PCI_FID("fid", S390PCIBusDevice, fid), >>       DEFINE_PROP_STRING("target", S390PCIBusDevice, target), >> +    DEFINE_PROP_BOOL("interp", S390PCIBusDevice, interp, true), >>       DEFINE_PROP_END_OF_LIST(), >>   }; > > Since this is something that the user can see, would it maybe make sense > to provide a full word instead of an abbreviation here? I.e. "interpret" > or "interpretation" instead of "interp" ? I'll go with "interpret" unless someone else has a strong opinion on it.