Re: [Qemu-devel] [PATCH v6 0/5] s390x: vfio-ap: guest dedicated crypto adapters

[Tony Krowiak <akrowiak@linux.ibm.com>]

On 08/08/2018 03:34 AM, Cornelia Huck wrote:
> On Tue, 7 Aug 2018 18:41:29 -0400
> Tony Krowiak <akrowiak@linux.ibm.com> wrote:
>
>> Ping
> Maybe send a new version when the kernel part is sent again? I don't
> think I had any further comments.

I'll consider that.

>
>> On 06/29/2018 06:47 PM, Tony Krowiak wrote:
>>> From: Tony Krowiak <akrowiak@linux.ibm.com>
>>>
>>> This patch series is the QEMU counterpart to the KVM/kernel support for
>>> guest dedicated crypto adapters. The KVM/kernel model is built on the
>>> VFIO mediated device framework and provides the infrastructure for
>>> granting exclusive guest access to crypto devices installed on the linux
>>> host. This patch series introduces a new QEMU command line option, QEMU
>>> object model and CPU model features to exploit the KVM/kernel model.
>>>
>>> See the detailed specifications for AP virtualization provided by this
>>> patch set in docs/vfio-ap.txt for a more complete discussion of the
>>> design introduced by this patch series.
>>>
>>> Note: This series implements the minimal viable product (MVP) and does not
>>>         provide support for hot plug/unplug or migration. The goal
>>>         of the MVP model is to solidify a base upon which these additional
>>>         features will be built.
>>>
>>> --
>>> v5 => v6 Change log:
>>> ===================
>>> * Added reset handling fo vfio-ap device
>>> * Added a bridge/bus to AP device object model - thanks to Halil Pasic
>>>
>>> v4 => v5 Change log:
>>> ===================
>>> * Added MAINTAINERS entries for VFIO AP
>>> * Added explanation for why we are only supporting zEC12 and newer CPU
>>>     models.
>>> * Changed CPU model feature qci=on|off to apqci=on|off
>>> * Misc. minor changes
>>>
>>> v3 => v4 Change log:
>>> ===================
>>> * Made vfio-ap device unpluggable for now
>>> * Renamed command line CPU model feature for QCI: qci=on -> apqci=on
>>> * Removed call to KVM_S390_VM_CRYPTO_INTERPRET_AP ioctl - ioctl was
>>>     removed from kernel and AP instruction interpretation is set from the
>>>     VFIO device driver
>>> * Added check to ensure only one vfio-ap device can be configured per
>>>     guest
>>> * Removed AP instruction interception handlers: AP instructions will be
>>>     interpreted by default if AP facilities are installed to handle the case
>>>     where feature ap=on and no vfio-ap device is configured for the guest.
>>>
>>>
>>> Tony Krowiak (5):
>>>     linux-headers: linux header updates for AP support
>>>     s390x/cpumodel: Set up CPU model for AP device support
>>>     s390x/ap: base Adjunct Processor (AP) object model
>>>     s390x/vfio: ap: Introduce VFIO AP device
>>>     s390: doc: detailed specifications for AP virtualization
>>>
>>>    MAINTAINERS                       |   14 +
>>>    default-configs/s390x-softmmu.mak |    1 +
>>>    docs/vfio-ap.txt                  |  649 +++++++++++++++++++++++++++++++++++++
>>>    hw/s390x/Makefile.objs            |    2 +
>>>    hw/s390x/ap-bridge.c              |   76 +++++
>>>    hw/s390x/ap-device.c              |   39 +++
>>>    hw/s390x/s390-virtio-ccw.c        |    4 +
>>>    hw/vfio/Makefile.objs             |    1 +
>>>    hw/vfio/ap.c                      |  183 +++++++++++
>>>    include/hw/s390x/ap-bridge.h      |   37 +++
>>>    include/hw/s390x/ap-device.h      |   38 +++
>>>    include/hw/vfio/vfio-common.h     |    1 +
>>>    linux-headers/asm-s390/kvm.h      |    2 +
>>>    linux-headers/linux/vfio.h        |    2 +
>>>    target/s390x/cpu_features.c       |    3 +
>>>    target/s390x/cpu_features_def.h   |    3 +
>>>    target/s390x/cpu_models.c         |    2 +
>>>    target/s390x/gen-features.c       |    3 +
>>>    target/s390x/kvm.c                |    1 +
>>>    19 files changed, 1061 insertions(+), 0 deletions(-)
>>>    create mode 100644 docs/vfio-ap.txt
>>>    create mode 100644 hw/s390x/ap-bridge.c
>>>    create mode 100644 hw/s390x/ap-device.c
>>>    create mode 100644 hw/vfio/ap.c
>>>    create mode 100644 include/hw/s390x/ap-bridge.h
>>>    create mode 100644 include/hw/s390x/ap-device.h
>>>