From: Paolo Bonzini <pbonzini@redhat.com>
To: Deepa Srinivasan <deepa.srinivasan@oracle.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
mark.kanda@oracle.com, qemu-block@nongnu.org,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix qemu crash when using scsi-block
Date: Thu, 23 Nov 2017 10:18:13 +0100 [thread overview]
Message-ID: <c4532ef7-6e05-d14a-21de-1b8381aa2112@redhat.com> (raw)
In-Reply-To: <E82650A0-F01C-4EE6-A024-A1AFAFCF3A3F@oracle.com>
On 23/11/2017 03:55, Deepa Srinivasan wrote:
> I agree that passing in QEMUIOVector to blk_aio_ioctl() as a holder of
> the void* buffer used in blk_aio_ioctl_entry() is unnecessary. But, as
> Kevin noted, read and write were using the QEMUIOVector in BlkRwCo.
>
> To avoid changes to the callers of blk_aio_ioctl(), I’ll change
> blk_aio_prwv() to take a void pointer instead of QEMUIOVector* and use a
> union to hold the buffer in BlkRwCo.
The union is unnecessary. A QEMUIOVector* can be stored in a void* just
fine.
Paolo
next prev parent reply other threads:[~2017-11-23 9:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 15:33 [Qemu-devel] [PATCH] block: Fix qemu crash when using scsi-block Deepa Srinivasan
2017-11-22 16:34 ` Paolo Bonzini
2017-11-22 18:06 ` Kevin Wolf
2017-11-22 19:24 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini
2017-11-23 2:55 ` Deepa Srinivasan
2017-11-23 9:18 ` Paolo Bonzini [this message]
2017-11-23 16:55 ` [Qemu-devel] " Deepa Srinivasan
2017-11-23 17:05 ` Deepa Srinivasan
2017-11-23 17:17 ` Paolo Bonzini
2017-11-23 17:29 ` Kevin Wolf
2017-11-23 17:31 ` Paolo Bonzini
2017-11-23 17:34 ` Kevin Wolf
2017-11-27 18:45 ` Deepa Srinivasan
2017-12-01 17:27 ` Deepa Srinivasan
2017-11-22 17:06 ` Stefan Hajnoczi
2017-11-22 18:04 ` Kevin Wolf
2017-11-23 10:23 ` Stefan Hajnoczi
2017-11-23 10:42 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4532ef7-6e05-d14a-21de-1b8381aa2112@redhat.com \
--to=pbonzini@redhat.com \
--cc=deepa.srinivasan@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=kwolf@redhat.com \
--cc=mark.kanda@oracle.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).