Re: [Qemu-devel] [PATCH v2 1/3] ui: install logo icons to $prefix/share/icons

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1936 bytes --]

On 1/10/19 6:00 AM, Daniel P. Berrangé wrote:
> QEMU currently installs loogs to $prefix/share/qemu/ which means no GUI

s/loogs/logos/

> toolkit or applications can find them by default.
> 
> The accepted standards for desktop applications declare that application
> logos / icons should be installed under $prefix/share/icons, so use this
> directory location.
> 
> Pre-rendered icons are provided at the standard sizes expected for GUI
> applications, along with the scalable SVG, to ensure maximum portability.
> 
> The PNGs are rendered from the SVG using inkscape, however, this is not
> wired up into the default make rules to avoid requiring inkscape as a
> mandatory tool in build systems / developer workstations..

double trailing '.'. I like that the rules for automating it are there
as a separate make target, and that they are not part of the default
build (and hence the generated files must live in git).  That said,...

> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---


> +++ b/ui/icons/Makefile
> @@ -0,0 +1,13 @@
> +
> +# Regenerate bitmaps from the SVG using inkscape CLI export
> +# and ImageMagick. Don't use ImageMagick for the initial
> +# SVG conversion, since it merely calls inkscape, but uses
> +# 96 DPI res resulting in poor quality output.

...should this comment mention that it is intentional that this target
is not part of 'make all'? Should the target be named 'maint-regenerate'
to call attention to the fact that it is a maintainer-specific target?

> +
> +regenerate:
> +	for s in 16 24 32 48 64 128 256 512; \
> +	do \
> +	    inkscape --without-gui --export-png=qemu_$${s}x$${s}.png \
> +		--export-width=$$s --export-height=$$s qemu.svg ; \
> +	done
> +	convert qemu_32x32.png qemu_32x32.bmp

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]