From: David Hildenbrand <david@redhat.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>,
Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 4/5] target/s390x: Fix shifting 32-bit values for more than 31 bits
Date: Thu, 13 Jan 2022 09:23:25 +0100 [thread overview]
Message-ID: <c47dc3fe-00e0-7ef5-4e47-9a1f8da4912d@redhat.com> (raw)
In-Reply-To: <20220112165016.226996-5-iii@linux.ibm.com>
On 12.01.22 17:50, Ilya Leoshkevich wrote:
> According to PoP, both 32- and 64-bit shifts use lowest 6 address
> bits. The current code special-cases 32-bit shifts to use only 5 bits,
> which is not correct. For example, shifting by 32 bits currently
> preserves the initial value, however, it's supposed zero it out
> instead.
>
> Fix by merging sh32 and sh64 and adapting CC calculation to shift
> values greater than 31.
>
> Fixes: cbe24bfa91d2 ("target-s390: Convert SHIFT, ROTATE SINGLE")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-01-13 8:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 16:50 [PATCH v4 0/5] target/s390x: Fix shift instructions Ilya Leoshkevich
2022-01-12 16:50 ` [PATCH v4 1/5] target/s390x: Fix SLDA sign bit index Ilya Leoshkevich
2022-01-12 16:50 ` [PATCH v4 2/5] target/s390x: Fix SRDA CC calculation Ilya Leoshkevich
2022-01-13 15:33 ` David Hildenbrand
2022-01-12 16:50 ` [PATCH v4 3/5] target/s390x: Fix cc_calc_sla_64() missing overflows Ilya Leoshkevich
2022-01-13 8:21 ` David Hildenbrand
2022-01-12 16:50 ` [PATCH v4 4/5] target/s390x: Fix shifting 32-bit values for more than 31 bits Ilya Leoshkevich
2022-01-13 8:23 ` David Hildenbrand [this message]
2022-01-12 16:50 ` [PATCH v4 5/5] tests/tcg/s390x: Test shift instructions Ilya Leoshkevich
2022-01-13 8:25 ` David Hildenbrand
2022-01-18 9:08 ` [PATCH v4 0/5] target/s390x: Fix " Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c47dc3fe-00e0-7ef5-4e47-9a1f8da4912d@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=iii@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).