From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] chardev: do not use short form boolean options in non-QemuOpts character device descriptions
Date: Thu, 25 Feb 2021 12:17:22 +0100 [thread overview]
Message-ID: <c47f4807-4325-97b8-423e-ead1a2c1701f@redhat.com> (raw)
In-Reply-To: <20210225111157.619188-1-pbonzini@redhat.com>
On 2/25/21 12:11 PM, Paolo Bonzini wrote:
> Options such as "-gdb" or "-serial" accept a part-QemuOpts part-parsed-by-hand
> character device description. Do not use short form boolean options in the
> QemuOpts part.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> chardev/char-socket.c | 10 +++++-----
> qapi/char.json | 4 ++--
> tests/guest-debug/run-test.py | 8 ++++----
> 3 files changed, 11 insertions(+), 11 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
prev parent reply other threads:[~2021-02-25 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 11:11 [PATCH] chardev: do not use short form boolean options in non-QemuOpts character device descriptions Paolo Bonzini
2021-02-25 11:17 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c47f4807-4325-97b8-423e-ead1a2c1701f@redhat.com \
--to=philmd@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).