From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9FE1D15D86 for ; Mon, 21 Oct 2024 12:27:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2rV5-0005eN-7K; Mon, 21 Oct 2024 08:27:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2rV3-0005e0-Gq for qemu-devel@nongnu.org; Mon, 21 Oct 2024 08:27:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2rV1-0007eh-NM for qemu-devel@nongnu.org; Mon, 21 Oct 2024 08:27:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729513622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1I0sRRzIsugI0UjhTszwRibAvSARmptC8OBycHgJ0a4=; b=guHaQdDrOn3/f6ZxBuZDqiHfIugvLXGhVX1tDH0JIPJZQLjAJsXIfVM2Sm+6aXwTqBwMVn G8SrjxKs7Cz1zmccUn7dlqhYBthobqBO302j3jX/NYrEjQ3bNtfTPg7RaoqHgj3I6gnqzB 6SDa689GY8b5jTpflSAb91Zk0cCeHqY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214-zwDYXdAcPsOjvHo9udiitw-1; Mon, 21 Oct 2024 08:27:01 -0400 X-MC-Unique: zwDYXdAcPsOjvHo9udiitw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43157e3521dso31689965e9.1 for ; Mon, 21 Oct 2024 05:27:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729513620; x=1730118420; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1I0sRRzIsugI0UjhTszwRibAvSARmptC8OBycHgJ0a4=; b=Ss6g3YesY0DoTbt1ievMoWPNM92/X9rlFDjSF/j+qc/MhF6bPwRnTBojZQKOxWmNZQ P46RqCH++6ii6p8p6NHdsmhSRlwfO3ARU5tUegmst9Dwa7GrsgMW641ZPOT6JEVo+F/+ v6SwRARHhIvZctFLmIg1GYWf33T294CV8jY65rEorUY1u2roE5ygW7WvIUvlU/qwpIig //LIfLEbeg+3h7iWIxmoJODvnJPXDYR4U8gbGknquob9+MnmP39D/5RYGST9Mlx8U2ML v1yNjgaXv0gyr7aawW0SV3O2RdqedPNic5BTvX8ZJuM6hYz02VKBHOtlF4pJh7ZVPSQj ONxg== X-Forwarded-Encrypted: i=1; AJvYcCVSWF5W8DDXbSW+7feW0bofF22z0LQIgulG/RrswnAQ2MYXClgJGesxHA9fR+ZFvqMwwMm855XkEfvu@nongnu.org X-Gm-Message-State: AOJu0Yw6W8qIwStQBJ1gubKNtyQA34Il6XxmAaS0++hwGEQQuv4g8wG7 WNcmixA567Xydw+rONa/+Qj6kGA9Os6mHBDF2yi24P07Nh/TcZvtGbyDzwkIFrxxjy+5scToGz+ S4j92dbnQiL4bSPHK2WGZKYoLYVx/lYz1EYcD8d9/D0m6QHW5oM1b X-Received: by 2002:a05:600c:674a:b0:431:54f3:11af with SMTP id 5b1f17b1804b1-431616ad566mr78781755e9.31.1729513619908; Mon, 21 Oct 2024 05:26:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2ES5AuEWFrP5DNmxgk83pTtH2PZ9/vLyTkN5PoUZsQLttPNqxEdxVeqF6QqC6HMMvKPJTNw== X-Received: by 2002:a05:600c:674a:b0:431:54f3:11af with SMTP id 5b1f17b1804b1-431616ad566mr78781615e9.31.1729513619516; Mon, 21 Oct 2024 05:26:59 -0700 (PDT) Received: from [192.168.0.7] (ip-109-42-50-24.web.vodafone.de. [109.42.50.24]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4316f570dd5sm56463025e9.3.2024.10.21.05.26.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Oct 2024 05:26:59 -0700 (PDT) Message-ID: Date: Mon, 21 Oct 2024 14:26:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] tests/functional: Convert most Aspeed machine tests To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , berrange@redhat.com References: <20241021115603.711116-1-clg@redhat.com> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20241021115603.711116-1-clg@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.421, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 21/10/2024 13.56, Cédric Le Goater wrote: > This is a simple conversion of the tests with some cleanups and > adjustments to match the new test framework. Replace the zephyr image > MD5 hashes with SHA256 hashes while at it. > > The SDK tests depend on a ssh class from avocado.utils which is > difficult to replace. To be addressed separately. > > Signed-off-by: Cédric Le Goater > --- ... > diff --git a/tests/functional/test_arm_aspeed.py b/tests/functional/test_arm_aspeed.py > new file mode 100644 > index 000000000000..9761fc06a454 > --- /dev/null > +++ b/tests/functional/test_arm_aspeed.py > @@ -0,0 +1,282 @@ > +#!/usr/bin/env python3 > +# > +# Functional test that boots the ASPEED SoCs with firmware > +# > +# Copyright (C) 2022 ASPEED Technology Inc > +# > +# SPDX-License-Identifier: GPL-2.0-or-later > + > +import os > +import time > +import subprocess > +import tempfile > + > +from qemu_test import LinuxKernelTest, Asset > +from qemu_test import exec_command_and_wait_for_pattern > +from qemu_test import interrupt_interactive_console_until_pattern > +from qemu_test import exec_command > +from qemu_test import has_cmd > +from qemu_test.utils import archive_extract > +from zipfile import ZipFile > +from unittest import skipUnless > + > +class AST1030Machine(LinuxKernelTest): Nit: Zephyr does not seem to be based on the Linux kernel, so I'd maybe keep QemuSystemTest for the AST1030Machine class. Anyway, it should not matter much, and the rest looks and works fine now, so: Reviewed-by: Thomas Huth Tested-by: Thomas Huth > + ASSET_ZEPHYR_1_04 = Asset( > + ('https://github.com/AspeedTech-BMC' > + '/zephyr/releases/download/v00.01.04/ast1030-evb-demo.zip'), > + '4ac6210adcbc61294927918707c6762483fd844dde5e07f3ba834ad1f91434d3') > + > + def test_ast1030_zephyros_1_04(self): > + self.set_machine('ast1030-evb') > + > + zip_file = self.ASSET_ZEPHYR_1_04.fetch() > + > + kernel_name = "ast1030-evb-demo/zephyr.elf" > + with ZipFile(zip_file, 'r') as zf: > + zf.extract(kernel_name, path=self.workdir) > + kernel_file = os.path.join(self.workdir, kernel_name) > + > + self.vm.set_console() > + self.vm.add_args('-kernel', kernel_file, '-nographic') > + self.vm.launch() > + self.wait_for_console_pattern("Booting Zephyr OS") > + exec_command_and_wait_for_pattern(self, "help", > + "Available commands") > + > + ASSET_ZEPHYR_1_07 = Asset( > + ('https://github.com/AspeedTech-BMC' > + '/zephyr/releases/download/v00.01.07/ast1030-evb-demo.zip'), > + 'ad52e27959746988afaed8429bf4e12ab988c05c4d07c9d90e13ec6f7be4574c') > + > + def test_ast1030_zephyros_1_07(self): > + self.set_machine('ast1030-evb') > + > + zip_file = self.ASSET_ZEPHYR_1_07.fetch() > + > + kernel_name = "ast1030-evb-demo/zephyr.bin" > + with ZipFile(zip_file, 'r') as zf: > + zf.extract(kernel_name, path=self.workdir) > + kernel_file = os.path.join(self.workdir, kernel_name) > + > + self.vm.set_console() > + self.vm.add_args('-kernel', kernel_file, '-nographic') > + self.vm.launch() > + self.wait_for_console_pattern("Booting Zephyr OS") > + for shell_cmd in [ > + 'kernel stacks', > + 'otp info conf', > + 'otp info scu', > + 'hwinfo devid', > + 'crypto aes256_cbc_vault', > + 'random get', > + 'jtag JTAG1 sw_xfer high TMS', > + 'adc ADC0 resolution 12', > + 'adc ADC0 read 42', > + 'adc ADC1 read 69', > + 'i2c scan I2C_0', > + 'i3c attach I3C_0', > + 'hash test', > + 'kernel uptime', > + 'kernel reboot warm', > + 'kernel uptime', > + 'kernel reboot cold', > + 'kernel uptime', > + ]: exec_command_and_wait_for_pattern(self, shell_cmd, "uart:~$") > + Thomas