From: Thomas Huth <thuth@redhat.com>
To: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Leif Lindholm <quic_llindhol@quicinc.com>,
Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 3/5] hw/arm/sbsa-ref: honor "-vga none" argument
Date: Wed, 24 May 2023 12:50:28 +0200 [thread overview]
Message-ID: <c4981714-e3d6-e035-cf88-338d8d018fbd@redhat.com> (raw)
In-Reply-To: <20230524102729.810892-4-marcin.juszkiewicz@linaro.org>
On 24/05/2023 12.27, Marcin Juszkiewicz wrote:
> In case someone wants to run without graphics card.
>
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> ---
> hw/arm/sbsa-ref.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> index 9c3e670ec6..c540b2f1ba 100644
> --- a/hw/arm/sbsa-ref.c
> +++ b/hw/arm/sbsa-ref.c
> @@ -649,7 +649,9 @@ static void create_pcie(SBSAMachineState *sms)
> }
> }
>
> - pci_create_simple(pci->bus, -1, "bochs-display");
> + if (vga_interface_type != VGA_NONE) {
> + pci_create_simple(pci->bus, -1, "bochs-display");
> + }
Once you extended pci_vga_init(), I think you should simply replace this
line with pci_vga_init(pci->bus) - then you get the handling for VGA_NONE
and other graphic adapters automatically (especially one could use "-vga
std" to switch back to the normal VGA card that was used in former times).
Thomas
next prev parent reply other threads:[~2023-05-24 10:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 10:27 [PATCH v3 0/5] hw/arm/sbsa-ref: sort out graphics a bit Marcin Juszkiewicz
2023-05-24 10:27 ` [PATCH v3 1/5] hw/arm: Use MachineClass->default_nic in the sbsa-ref machine Marcin Juszkiewicz
2023-05-24 14:59 ` Richard Henderson
2023-05-24 10:27 ` [PATCH v3 2/5] Add Bochs to list of vga_interfaces Marcin Juszkiewicz
2023-05-24 10:48 ` Thomas Huth
2023-05-24 14:59 ` Richard Henderson
2023-05-24 10:27 ` [PATCH v3 3/5] hw/arm/sbsa-ref: honor "-vga none" argument Marcin Juszkiewicz
2023-05-24 10:50 ` Thomas Huth [this message]
2023-05-24 14:59 ` Richard Henderson
2023-05-24 10:27 ` [PATCH v3 4/5] hw/arm/sbsa-ref: add gfx card only if we have pci Marcin Juszkiewicz
2023-05-24 10:27 ` [PATCH v3 5/5] hw/arm/sbsa-ref: use MachineClass->default_display Marcin Juszkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4981714-e3d6-e035-cf88-338d8d018fbd@redhat.com \
--to=thuth@redhat.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).