From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82AF6C433F5 for ; Wed, 10 Nov 2021 21:57:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 183D3610A2 for ; Wed, 10 Nov 2021 21:57:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 183D3610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:60808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkvbE-0002TE-SX for qemu-devel@archiver.kernel.org; Wed, 10 Nov 2021 16:57:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkva6-0001RR-Cl for qemu-devel@nongnu.org; Wed, 10 Nov 2021 16:56:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20448) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkva3-0007i1-72 for qemu-devel@nongnu.org; Wed, 10 Nov 2021 16:56:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636581389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dur4v0qgDy7pYtypuCk//uYsMsG2e204/RCR//3mbfY=; b=jThUQ/8FWXY5G1STL4pM5aFKr1QVRIX4tdVCLDPEhEpFKpVXwlPliipmEyxccsVtsdO/2L QgPj4TC3ImTIYGIi2M1n+TloqLV2XpQ6e0dDzpDqLaaicp+1L4K2kAddpMLjwm7Pk4gOC+ aQNsCtIPvB1AnOhhADRFjmJ0yB+RMh0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-236-i0cAvCaPNvCz1zQna6oblQ-1; Wed, 10 Nov 2021 16:56:28 -0500 X-MC-Unique: i0cAvCaPNvCz1zQna6oblQ-1 Received: by mail-wm1-f70.google.com with SMTP id n16-20020a05600c3b9000b003331973fdbbso1792665wms.0 for ; Wed, 10 Nov 2021 13:56:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Dur4v0qgDy7pYtypuCk//uYsMsG2e204/RCR//3mbfY=; b=a+IBRHmjQuDlAOLMt6Dj/dLsUGOrGWZgoX19CZ8fmqIW24z9DfuuIYY7+bmRoVoKeW BK8iXBakniOlZMQtndNO4E/+mrCVKKLB8XjjYvTON9wvjHGD/wibguFMiqpvpEh6/2GZ bM8246mC0XQRaSw+eBRwPdyM+0D92rRkHA2e32cOEH6qMb7Cv/Bn3x4sacR726PvFwGw 0xeJLe7oVRIkEOVGBgx32wZQvu+2wZSgUjhj01d/X2mWExWMzRi0E2eDFGle6/hZO191 8wCQwP1u0ce8rp5bKBz70C3eoiikGGmQXy3rX6YZkqH0JAvoMezEPX4wYtUM//pSwc5u remA== X-Gm-Message-State: AOAM531IebsY0ArzfKQConYRxtoYkZIp72gVofWZqBLetUfHfcjvqSkW lyP++2dcKPCB5+60cNif358TbSKP/RLZ22Vc/kkjJ+WIIH1Vxu5L/GuM3LRp6LzS64j/pNg3ai4 FlWnBm+0h9+X05i8= X-Received: by 2002:a1c:1fd6:: with SMTP id f205mr20161398wmf.98.1636581387412; Wed, 10 Nov 2021 13:56:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQYR0ZaJ89jK0B6+9ebA5AEix1V8A1Hz8p+yjxteQ/7tZvSeu08aDLPC4K7lbmqzZc5fOMYQ== X-Received: by 2002:a1c:1fd6:: with SMTP id f205mr20161374wmf.98.1636581387215; Wed, 10 Nov 2021 13:56:27 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id f3sm6734838wmb.12.2021.11.10.13.56.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Nov 2021 13:56:26 -0800 (PST) Message-ID: Date: Wed, 10 Nov 2021 22:56:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] qmp: Stabilize preconfig To: Markus Armbruster , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <87bl3dfg9v.fsf@dusky.pond.sub.org> <87zgqlzmxi.fsf@dusky.pond.sub.org> From: Paolo Bonzini In-Reply-To: <87zgqlzmxi.fsf@dusky.pond.sub.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -51 X-Spam_score: -5.2 X-Spam_bar: ----- X-Spam_report: (-5.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.678, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?B?TWljaGFsIFByw612b3puw61r?= , qemu-devel@nongnu.org, Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > On 11/3/21 09:02, Markus Armbruster wrote: >> I wonder whether we really have to step through three states >> >> x-exit-preconfig cont >> preconfig ---> pre run ---> run >> >> and not two >> >> cont >> pre run ---> run Devices would be hotplugged between x-exit-preconfig and cont, and part of the machine until x-exit-preconfig; so there is a need for something like x-exit-preconfig. In my prototype of a QMP-only binary, the idea would be that there wouldn't be a single x-exit-preconfig command, but "cont", "migrate-incoming", "finish-machine-init" (the stable replacement for x-exit-preconfig) and "loadvm" would all complete the configuration of the machine. "finish-machine-init" would do nothing else, the others would continue with whatever they were supposed to do. >> Which of the queries you need work only between x-exit-preconfig and -S? > > Well before x-exit-preconfig, QMP only permits a very small number > of commands - QEMU has loosened that up a bit, but I don't think anyone > has checked whether there's enough to cover libvirt's current usage yet. Indeed I looked at the commands that operate on the backends, but not that much at query commands. Paolo