From: Cole Robinson <crobinso@redhat.com>
To: "Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] Move qemu.sasl to contrib/
Date: Thu, 8 Jul 2021 16:49:24 -0400 [thread overview]
Message-ID: <c4b6187f-49df-b94a-cad9-2773392671f3@redhat.com> (raw)
In-Reply-To: <CAFEAcA-NER3jDVoTnZN4T=gtzOTOmWvUMNOcPikjcj6Ay3NQJg@mail.gmail.com>
On 7/8/21 3:18 PM, Peter Maydell wrote:
> On Thu, 8 Jul 2021 at 20:14, Daniel P. Berrangé <berrange@redhat.com> wrote:
>>
>> On Thu, Jul 08, 2021 at 02:39:57PM -0400, Cole Robinson wrote:
>>> It's not installed in any way, so seems like contrib/ material
>>
>> Not really.
>>
>> Contrib is stuff that is included on an ad-hoc basis with no
>> commitment to support and no guarantee that it is working at
>> all. Yes, there is some stuff in contrib/ that doesn't
>> belong there based on this definition, and should be moved
>> out.
>
> More generally, I would like to see us get rid of contrib/
> entirely. We should either support stuff (and have it in
> sensible places in the source tree) or kick it out.
>
qemu.sasl to ui/ dir then?
Do you think we should install qemu.sasl to /etc/sasl2/qemu.conf? Its
what Fedora/RHEL packaging does by hand for qemu. And what libvirt does
for its equivalent config file
Thanks,
Cole
next prev parent reply other threads:[~2021-07-08 20:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 18:39 [PATCH] Move qemu.sasl to contrib/ Cole Robinson
2021-07-08 18:45 ` Daniel P. Berrangé
2021-07-08 19:18 ` Peter Maydell
2021-07-08 20:49 ` Cole Robinson [this message]
2021-07-08 23:22 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4b6187f-49df-b94a-cad9-2773392671f3@redhat.com \
--to=crobinso@redhat.com \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).