From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8479FC25B4E for ; Sun, 22 Jan 2023 08:26:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJVfS-0000O3-TP; Sun, 22 Jan 2023 03:25:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJVfP-0000Mw-7c for qemu-devel@nongnu.org; Sun, 22 Jan 2023 03:25:31 -0500 Received: from mail.xen0n.name ([115.28.160.31] helo=mailbox.box.xen0n.name) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJVfL-0004Fx-54 for qemu-devel@nongnu.org; Sun, 22 Jan 2023 03:25:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1674375917; bh=DtwXxY/RdxPWoh3wfvEzg7Tzww3a6Z2bU/8U37lhDHo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kQZEnL5yzy5yKIrYfQgoev+bmweFce3wxZM4DNeBOkMikzidI7Ezgo6JHbvp2fBTU XAD5atqVwH6oEQYaZaOaO8xIojtVYebkBo8H+7UyMiI/2g9XhrkUsvTYRZlbcr+kmH iENT/ht5ZuZ4qn92+UyMCwcrN1UuVQDupiGtQFWA= Received: from [192.168.9.172] (unknown [101.88.135.165]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id 18A5D60106; Sun, 22 Jan 2023 16:25:17 +0800 (CST) Message-ID: Date: Sun, 22 Jan 2023 16:20:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/111.0 Thunderbird/111.0a1 Subject: Re: [PATCH v2 05/10] tcg/loongarch64: Update tcg-insn-defs.c.inc Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: git@xen0n.name References: <20230118011123.392823-1-richard.henderson@linaro.org> <20230118011123.392823-6-richard.henderson@linaro.org> From: WANG Xuerui In-Reply-To: <20230118011123.392823-6-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=115.28.160.31; envelope-from=i.qemu@xen0n.name; helo=mailbox.box.xen0n.name X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.092, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/18/23 09:11, Richard Henderson wrote: > Regenerate with ADDU16I included: > > $ cd loongarch-opcodes/scripts/go > $ go run ./genqemutcgdefs > $QEMU/tcg/loongarch64/tcg-insn-defs.c.inc > > Signed-off-by: Richard Henderson > --- > tcg/loongarch64/tcg-insn-defs.c.inc | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > mode change 100644 => 100755 tcg/loongarch64/tcg-insn-defs.c.inc > > diff --git a/tcg/loongarch64/tcg-insn-defs.c.inc b/tcg/loongarch64/tcg-insn-defs.c.inc > old mode 100644 > new mode 100755 > index d162571856..b5bb0c5e73 > --- a/tcg/loongarch64/tcg-insn-defs.c.inc > +++ b/tcg/loongarch64/tcg-insn-defs.c.inc > @@ -4,7 +4,7 @@ > * > * This file is auto-generated by genqemutcgdefs from > * https://github.com/loongson-community/loongarch-opcodes, > - * from commit 961f0c60f5b63e574d785995600c71ad5413fdc4. > + * from commit 25ca7effe9d88101c1cf96c4005423643386d81f. > * DO NOT EDIT. > */ > > @@ -74,6 +74,7 @@ typedef enum { > OPC_ANDI = 0x03400000, > OPC_ORI = 0x03800000, > OPC_XORI = 0x03c00000, > + OPC_ADDU16I_D = 0x10000000, > OPC_LU12I_W = 0x14000000, > OPC_CU32I_D = 0x16000000, > OPC_PCADDU2I = 0x18000000, > @@ -710,6 +711,13 @@ tcg_out_opc_xori(TCGContext *s, TCGReg d, TCGReg j, uint32_t uk12) > tcg_out32(s, encode_djuk12_insn(OPC_XORI, d, j, uk12)); > } > > +/* Emits the `addu16i.d d, j, sk16` instruction. */ > +static void __attribute__((unused)) > +tcg_out_opc_addu16i_d(TCGContext *s, TCGReg d, TCGReg j, int32_t sk16) > +{ > + tcg_out32(s, encode_djsk16_insn(OPC_ADDU16I_D, d, j, sk16)); > +} > + > /* Emits the `lu12i.w d, sj20` instruction. */ > static void __attribute__((unused)) > tcg_out_opc_lu12i_w(TCGContext *s, TCGReg d, int32_t sj20) Reviewed-by: WANG Xuerui