From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FEEECA9EAF for ; Thu, 24 Oct 2019 12:44:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2232A205C9 for ; Thu, 24 Oct 2019 12:44:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2232A205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNcTE-0005G4-PQ for qemu-devel@archiver.kernel.org; Thu, 24 Oct 2019 08:44:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41671) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNbbO-0003Qq-RG for qemu-devel@nongnu.org; Thu, 24 Oct 2019 07:48:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNbbN-0007sx-Jx for qemu-devel@nongnu.org; Thu, 24 Oct 2019 07:48:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56162) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iNbbI-0007ml-Ji for qemu-devel@nongnu.org; Thu, 24 Oct 2019 07:48:23 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3FEE4C049E12 for ; Thu, 24 Oct 2019 11:48:16 +0000 (UTC) Received: by mail-wr1-f72.google.com with SMTP id a6so9908702wru.1 for ; Thu, 24 Oct 2019 04:48:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6ltgiqHhNHaXdrzNuL6lkoiWjNGQwyyjMPT5XIbOJzU=; b=t86cJXnbxsFy2yXrF81Q/I7RDl7b8iC+PU31SiFqvD2oKqFhTaXbkG6Lgyzf78L8Mu srqfaIlTfdhUk6RBYi4Lg1u59Dac/lAT98yUOEgqmJoMuQw9XUMT2wySUIA1QFpysyiQ /EP4zTLQ1QehlubF1/XtstNf8dIFaiRhtA/V0FF/pRZ0C/zn8d9BXUVB/HK0ov1UVlXM y36HB778/K2KdrSh2TVzxPNATb4O5HV97KTi3rTiBrlrQ9Q8f5Ii7dDkLNfQQhTx60RV Ym2e6aajBlnDLCbb4JLM1G2xAnCiUhsWLkgtBx0xYx2t74vboSWPRohWFC0StUO7QhNz p1bg== X-Gm-Message-State: APjAAAU8eG+DkZntFTCokyy7Uw42NBSVbsnsTM9OMlRqMEEqyLYO/x/l eKwnvXt1D5RgQ9uc7um1ZJQLqpF4oe7eIX1gWQZF7TNSGiGj8FVftc3IlIozjIrGw1acbFNYkU/ zXjbtbtS/RCggIDU= X-Received: by 2002:a05:600c:28d:: with SMTP id 13mr4839664wmk.100.1571917694940; Thu, 24 Oct 2019 04:48:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqyxrVSSXrMjGzB9j/Y2FPvFBtxS02wScHByedkcYPwJfV978muxLTl39lA1OyUxiVOtstataw== X-Received: by 2002:a05:600c:28d:: with SMTP id 13mr4839587wmk.100.1571917693909; Thu, 24 Oct 2019 04:48:13 -0700 (PDT) Received: from [192.168.1.41] (129.red-83-57-174.dynamicip.rima-tde.net. [83.57.174.129]) by smtp.gmail.com with ESMTPSA id d8sm11646908wrr.71.2019.10.24.04.48.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Oct 2019 04:48:12 -0700 (PDT) Subject: Re: [PATCH v3 23/33] dp8393x: replace PROP_PTR with PROP_LINK To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= References: <20191023173154.30051-1-marcandre.lureau@redhat.com> <20191023173154.30051-24-marcandre.lureau@redhat.com> <06288994-a5d3-038d-794e-ed63acdadd95@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Thu, 24 Oct 2019 13:48:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , "Michael S. Tsirkin" , Jason Wang , Mark Cave-Ayland , qemu-devel , KONRAD Frederic , "Edgar E. Iglesias" , Paul Burton , Peter Maydell , Magnus Damm , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Artyom Tarasenko , Eduardo Habkost , Fabien Chouteau , qemu-arm , Richard Henderson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Aleksandar Rikalo , qemu-ppc , Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/24/19 1:12 PM, Marc-Andr=C3=A9 Lureau wrote: > On Thu, Oct 24, 2019 at 1:02 AM Philippe Mathieu-Daud=C3=A9 > wrote: >> >> On 10/23/19 7:31 PM, Marc-Andr=C3=A9 Lureau wrote: >>> Link property is the correct way to pass a MemoryRegion to a device >>> for DMA purposes. >>> >>> Sidenote: as a sysbus device, this remains non-usercreatable >>> even though we can drop the specific flag here. >>> >>> Signed-off-by: Marc-Andr=C3=A9 Lureau >>> Reviewed-by: Peter Maydell >>> --- >>> hw/mips/mips_jazz.c | 3 ++- >>> hw/net/dp8393x.c | 7 +++---- >>> 2 files changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c >>> index 8d010a0b6e..878925a963 100644 >>> --- a/hw/mips/mips_jazz.c >>> +++ b/hw/mips/mips_jazz.c >>> @@ -284,7 +284,8 @@ static void mips_jazz_init(MachineState *machine, >>> dev =3D qdev_create(NULL, "dp8393x"); >>> qdev_set_nic_properties(dev, nd); >>> qdev_prop_set_uint8(dev, "it_shift", 2); >>> - qdev_prop_set_ptr(dev, "dma_mr", rc4030_dma_mr); >>> + object_property_set_link(OBJECT(dev), OBJECT(rc4030_dma_= mr), >>> + "dma_mr", &error_abort); >>> qdev_init_nofail(dev); >>> sysbus =3D SYS_BUS_DEVICE(dev); >>> sysbus_mmio_map(sysbus, 0, 0x80001000); >>> diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c >>> index a5678e11fa..946c7a8f64 100644 >>> --- a/hw/net/dp8393x.c >>> +++ b/hw/net/dp8393x.c >>> @@ -173,7 +173,7 @@ typedef struct dp8393xState { >>> int loopback_packet; >>> >>> /* Memory access */ >>> - void *dma_mr; >>> + MemoryRegion *dma_mr; >>> AddressSpace as; >>> } dp8393xState; >>> >>> @@ -922,7 +922,8 @@ static const VMStateDescription vmstate_dp8393x =3D= { >>> >>> static Property dp8393x_properties[] =3D { >>> DEFINE_NIC_PROPERTIES(dp8393xState, conf), >>> - DEFINE_PROP_PTR("dma_mr", dp8393xState, dma_mr), >>> + DEFINE_PROP_LINK("dma_mr", dp8393xState, dma_mr, >>> + TYPE_MEMORY_REGION, MemoryRegion *), >>> DEFINE_PROP_UINT8("it_shift", dp8393xState, it_shift, 0), >>> DEFINE_PROP_END_OF_LIST(), >>> }; >>> @@ -936,8 +937,6 @@ static void dp8393x_class_init(ObjectClass *klass= , void *data) >>> dc->reset =3D dp8393x_reset; >>> dc->vmsd =3D &vmstate_dp8393x; >>> dc->props =3D dp8393x_properties; >>> - /* Reason: dma_mr property can't be set */ >>> - dc->user_creatable =3D false; >> >> Patch is OK except this user_creatable change I don't understand. >=20 > It's a sysbus device, so it's not user-creatable anyway. I'll add a > commit comment. With comment: Reviewed-by: Philippe Mathieu-Daud=C3=A9 >=20 >> >>> } >>> >>> static const TypeInfo dp8393x_info =3D { >>>