From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A36CAC433E0 for ; Wed, 17 Jun 2020 11:40:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E5F12070A for ; Wed, 17 Jun 2020 11:40:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JXBaXoTE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E5F12070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlWQs-0002qO-N7 for qemu-devel@archiver.kernel.org; Wed, 17 Jun 2020 07:40:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlWQ5-0002Aw-BI for qemu-devel@nongnu.org; Wed, 17 Jun 2020 07:39:54 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:36762 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jlWQ3-0002S2-PS for qemu-devel@nongnu.org; Wed, 17 Jun 2020 07:39:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592393991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=+A3OzC8YqMZn3QGL8JSkuLnC6+2WWU53BGSNIa7D090=; b=JXBaXoTE+prx5o5SUDbNjclabzN/fieq0XtZX0YAxL0blTIdEJig3rE6iqtHrLwnnh5uCA KE9IQEDQaz21TFnE3ux3ud9hNESfmUuX1zT2FXCctzOTyLTNtGb8MoQJefbUwGOpv3fft/ W7non99SGqvqOxcmQeepohV2KZ1wDPE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-225-Kk4d2p3hOr2nBpUn281m1A-1; Wed, 17 Jun 2020 07:39:49 -0400 X-MC-Unique: Kk4d2p3hOr2nBpUn281m1A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1DD78134D3; Wed, 17 Jun 2020 11:39:48 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-131.ams2.redhat.com [10.36.112.131]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BA4E60BE2; Wed, 17 Jun 2020 11:39:47 +0000 (UTC) Subject: Re: [PATCH 2/5] iotests/041: Skip test_small_target for qed To: Max Reitz , qemu-block@nongnu.org References: <20200617104822.27525-1-mreitz@redhat.com> <20200617104822.27525-3-mreitz@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: Date: Wed, 17 Jun 2020 13:39:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200617104822.27525-3-mreitz@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/17 01:42:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 17/06/2020 12.48, Max Reitz wrote: > qed does not support shrinking images, so the test_small_target method > should be skipped to keep 041 passing. > > Fixes: 16cea4ee1c8e5a69a058e76f426b2e17974d8d7d > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/041 | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 > index 601c756117..b843f88a66 100755 > --- a/tests/qemu-iotests/041 > +++ b/tests/qemu-iotests/041 > @@ -277,6 +277,8 @@ class TestSingleBlockdev(TestSingleDrive): > result = self.vm.run_job('job0') > self.assertEqual(result, 'Source and target image have different sizes') > > + # qed does not support shrinking > + @iotests.skip_for_formats(('qed')) > def test_small_target(self): > self.do_test_target_size(self.image_len // 2) Great, now "check -qed 041" works fine for me again! Thanks! Tested-by: Thomas Huth