From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bq3To-00085Q-FK for qemu-devel@nongnu.org; Fri, 30 Sep 2016 15:28:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bq3Tm-0005OV-Gu for qemu-devel@nongnu.org; Fri, 30 Sep 2016 15:28:19 -0400 References: <20160928205602.17275-1-mreitz@redhat.com> <20160928205602.17275-4-mreitz@redhat.com> From: Eric Blake Message-ID: Date: Fri, 30 Sep 2016 14:28:10 -0500 MIME-Version: 1.0 In-Reply-To: <20160928205602.17275-4-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kFgUjcv11SdEkmJH5KwcGV4lRQbOklvGH" Subject: Re: [Qemu-devel] [PATCH v4 03/12] block/nbd: Default port in nbd_refresh_filename() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Paolo Bonzini , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kFgUjcv11SdEkmJH5KwcGV4lRQbOklvGH From: Eric Blake To: Max Reitz , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Paolo Bonzini , Markus Armbruster Message-ID: Subject: Re: [PATCH v4 03/12] block/nbd: Default port in nbd_refresh_filename() References: <20160928205602.17275-1-mreitz@redhat.com> <20160928205602.17275-4-mreitz@redhat.com> In-Reply-To: <20160928205602.17275-4-mreitz@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/28/2016 03:55 PM, Max Reitz wrote: > Instead of not emitting the port in nbd_refresh_filename(), just set it= > to the default if the user did not specify it. This makes the logic a > bit simpler. >=20 > Signed-off-by: Max Reitz > --- > block/nbd.c | 19 ++++++------------- > 1 file changed, 6 insertions(+), 13 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kFgUjcv11SdEkmJH5KwcGV4lRQbOklvGH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX7rzKAAoJEKeha0olJ0NquroH/jtgL2FpjFkdet542CU9wr4K M8Vop5GCgLS8R9h/qz3t334wVRarQ/KI8Lo2SozzgBpcE/gQiPqi7bKR5Nn9ed/a YbbkevgcDAQOpIT07TBC6OZdfTJKHVqtfoBc+pPa/7j8dM381mY9cPPWU8GEJ1wa 6p5kgzqw5ZnsvyJcxnsh3IR69/qlw34+061B8hW7tTV0ceqdkfqhbKGtz29mP4hF aMhuvDcCpD2gKOkWWDlddKINkNkLsCvpXc5/3rEbpYDysEmKdTyNJzxd8i1DU14P J+xTPVbOl2oMOsLuW9eXhoHZK6qldbPqe5DDoQeoBDkSqeJtoRmcX66INETtbI0= =zvta -----END PGP SIGNATURE----- --kFgUjcv11SdEkmJH5KwcGV4lRQbOklvGH--