From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40812)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <philippe.mathieu.daude@gmail.com>)
	id 1fbTZZ-0001PB-Rw
	for qemu-devel@nongnu.org; Fri, 06 Jul 2018 12:27:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <philippe.mathieu.daude@gmail.com>)
	id 1fbTZU-0003Ra-Us
	for qemu-devel@nongnu.org; Fri, 06 Jul 2018 12:27:05 -0400
Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?=
	<philippe.mathieu.daude@gmail.com>
References: <20180706155127.7483-1-f4bug@amsat.org>
	<20180706155127.7483-3-f4bug@amsat.org>
	<CAFEAcA_rKe5MrPt36EAYjxB5TDREb9Ea+vj8u4kVPgamLDFiog@mail.gmail.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <f4bug@amsat.org>
Message-ID: <c5000a69-8309-cb26-feeb-a70d1d9107ee@amsat.org>
Date: Fri, 6 Jul 2018 13:26:56 -0300
MIME-Version: 1.0
In-Reply-To: <CAFEAcA_rKe5MrPt36EAYjxB5TDREb9Ea+vj8u4kVPgamLDFiog@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH for-3.0 2/3] linux-user: Do not report
 "syscall not implemented" by default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>, Riku Voipio <riku.voipio@iki.fi>, Laurent Vivier <laurent@vivier.eu>, QEMU Developers <qemu-devel@nongnu.org>

On 07/06/2018 01:08 PM, Peter Maydell wrote:
> On 6 July 2018 at 16:51, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>> This can still be reported using the "-d unimp" command line option.
>>
>> Code change produced with:
>>
>>   git ls-files linux-user | \
>>   xargs sed -i -E 's/fprintf\(stderr,\s?(".*not implemented\\n")\);/qemu_log_mask(LOG_UNIMP, \1);/g'
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  linux-user/cris/signal.c       | 4 ++--
>>  linux-user/microblaze/signal.c | 4 ++--
>>  linux-user/nios2/signal.c      | 2 +-
>>  linux-user/sparc/signal.c      | 4 ++--
>>  4 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/linux-user/cris/signal.c b/linux-user/cris/signal.c
>> index 0b405247cf..1e02194377 100644
>> --- a/linux-user/cris/signal.c
>> +++ b/linux-user/cris/signal.c
>> @@ -146,7 +146,7 @@ void setup_rt_frame(int sig, struct target_sigaction *ka,
>>                      target_siginfo_t *info,
>>                       target_sigset_t *set, CPUCRISState *env)
>>  {
>> -    fprintf(stderr, "CRIS setup_rt_frame: not implemented\n");
>> +    qemu_log_mask(LOG_UNIMP, "setup_rt_frame: not implemented\n");
> 
> Your regex seems to have gone a bit awry here, because it's lost
> the "CRIS" part of the string (similarly below).

Oh I deliberately dropped it when using 'git add -p' after the regex
because I noticed neither nios2 nor sparc arch were using it, and I
don't think this is a relevant information.

Do you prefer I restore them, I reword the commit message, or even add
similar description for the nios2/sparc?

Thanks,

Phil.