From: Ninad Palsule <ninad@linux.vnet.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>,
"Ninad Palsule" <ninad@linux.ibm.com>,
qemu-devel@nongnu.org
Cc: joel@jms.id.au, andrew@aj.id.au, stefanb@linux.ibm.com
Subject: Re: [PATCH 1/3] docs: Add support for TPM devices over I2C bus
Date: Thu, 23 Mar 2023 17:11:42 -0500 [thread overview]
Message-ID: <c5079a3e-aea6-1390-1bc4-e657d2b94b97@linux.vnet.ibm.com> (raw)
In-Reply-To: <ae61d505-b656-a362-8a80-35f266296e2a@kaod.org>
On 3/23/23 2:49 AM, Cédric Le Goater wrote:
> On 3/23/23 04:01, Ninad Palsule wrote:
>> This is a documentation change for I2C TPM device support.
>>
>> Qemu already supports devices attached to ISA and sysbus.
>> This drop adds support for the I2C bus attached TPM devices.
>>
>> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
>>
>> ---
>> V2:
>>
>> Incorporated Stephen's review comments
>> - Added example in the document.
>> ---
>> docs/specs/tpm.rst | 20 +++++++++++++++++++-
>> 1 file changed, 19 insertions(+), 1 deletion(-)
>>
>> diff --git a/docs/specs/tpm.rst b/docs/specs/tpm.rst
>> index 535912a92b..bf7249b09c 100644
>> --- a/docs/specs/tpm.rst
>> +++ b/docs/specs/tpm.rst
>> @@ -21,11 +21,15 @@ QEMU files related to TPM TIS interface:
>> - ``hw/tpm/tpm_tis_common.c``
>> - ``hw/tpm/tpm_tis_isa.c``
>> - ``hw/tpm/tpm_tis_sysbus.c``
>> + - ``hw/tpm/tpm_tis_i2c.c``
>> - ``hw/tpm/tpm_tis.h``
>> Both an ISA device and a sysbus device are available. The former is
>> used with pc/q35 machine while the latter can be instantiated in the
>> -Arm virt machine.
>> +Arm virt machine. An I2C device support is also added which can be
>> +instantiated in the arm based emulation machine. An I2C device is also
>> +supported for the Arm virt machine. This device only supports the
>> +TPM 2 protocol.
>> CRB interface
>> -------------
>> @@ -348,6 +352,20 @@ In case an Arm virt machine is emulated, use the
>> following command line:
>> -drive if=pflash,format=raw,file=flash0.img,readonly=on \
>> -drive if=pflash,format=raw,file=flash1.img
>> +In case a Rainier bmc machine is emulated, use the following
>> command line:
>> +
>> +.. code-block:: console
>> +
>> + qemu-system-arm -M rainier-bmc -nographic \
>> + -kernel ${IMAGEPATH}/fitImage-linux.bin \
>> + -dtb ${IMAGEPATH}/aspeed-bmc-ibm-rainier.dtb \
>> + -initrd ${IMAGEPATH}/obmc-phosphor-initramfs.rootfs.cpio.xz \
>> + -drive
>> file=${IMAGEPATH}/obmc-phosphor-image.rootfs.wic.qcow2,if=sd,index=2\
>> + -net nic -net
>> user,hostfwd=:127.0.0.1:2222-:22,hostfwd=:127.0.0.1:2443-:443\
>> + -chardev socket,id=chrtpm,path=/tmp/mytpm1/swtpm-sock \
>> + -tpmdev emulator,id=tpm0,chardev=chrtpm \
>> + -device tpm-tis-i2c,tpmdev=tpm0,bus=aspeed.i2c.bus.12,address=0x2e
>
>
> The rainier images are not the easiest to find. Could we use an
> AST2600 EVB
> machine instead and instantiate the device from user space ? see commit
> 3302184f7f or 7a7308eae0.
>
Ok, I will check on AST2600 EVB machine. The rainier images are
available here:
https://jenkins.openbmc.org/job/ci-openbmc/lastSuccessfulBuild/distro=ubuntu,label=docker-builder,target=p10bmc/artifact/openbmc/build/tmp/deploy/images/p10bmc/
Thanks for the review.
Ninad
> Thanks,
>
> C.
>
>> In case SeaBIOS is used as firmware, it should show the TPM menu item
>> after entering the menu with 'ESC'.
>
next prev parent reply other threads:[~2023-03-23 23:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 3:01 [PATCH 0/3] Add support for TPM devices over I2C bus Ninad Palsule
2023-03-23 3:01 ` [PATCH 1/3] docs: " Ninad Palsule
2023-03-23 7:49 ` Cédric Le Goater
2023-03-23 22:11 ` Ninad Palsule [this message]
2023-03-24 3:23 ` Ninad Palsule
2023-03-24 5:11 ` Ninad Palsule
2023-03-24 8:01 ` Cédric Le Goater
2023-03-24 12:50 ` Ninad Palsule
2023-03-23 3:01 ` [PATCH 2/3] TPM TIS: " Ninad Palsule
2023-03-23 7:44 ` Cédric Le Goater
2023-03-23 15:35 ` Ninad Palsule
2023-03-23 3:01 ` [PATCH 3/3] New I2C: " Ninad Palsule
2023-03-23 8:37 ` Cédric Le Goater
2023-03-23 22:32 ` Ninad Palsule
2023-03-24 8:06 ` Cédric Le Goater
2023-03-23 12:18 ` Stefan Berger
2023-03-23 20:07 ` Ninad Palsule
2023-03-23 7:23 ` [PATCH 0/3] " Cédric Le Goater
2023-03-23 22:35 ` Ninad Palsule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5079a3e-aea6-1390-1bc4-e657d2b94b97@linux.vnet.ibm.com \
--to=ninad@linux.vnet.ibm.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=ninad@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).