From: Richard Henderson <richard.henderson@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH v2] linux-user: fix mmap_find_vma_reserved()
Date: Wed, 11 Jul 2018 15:44:27 -0500 [thread overview]
Message-ID: <c50e56af-0eff-afff-4704-b01dee538581@linaro.org> (raw)
In-Reply-To: <515ab6e6-14b3-2687-18b9-582d63b82903@vivier.eu>
On 07/11/2018 01:27 PM, Laurent Vivier wrote:
> Richard,
>
> I think this fix could be merged into your "linux-user: Fix shmat
> emulation by honoring host SHMLBA" patch, by adding something like this
> instead:
Well, not "instead", but "in addition".
Nothing works right when the guest adjustment itself is unaligned, as is the
case with reserved_va as you noted, and with (non-reserved) guest_base as I
noted in that patch.
For v2, I'll split the guest_base fix out to a separate patch.
r~
next prev parent reply other threads:[~2018-07-11 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 16:40 [Qemu-devel] [PATCH v2] linux-user: fix mmap_find_vma_reserved() Laurent Vivier
2018-07-11 18:27 ` Laurent Vivier
2018-07-11 20:44 ` Richard Henderson [this message]
2018-07-11 20:41 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c50e56af-0eff-afff-4704-b01dee538581@linaro.org \
--to=richard.henderson@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).