qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: willianr@redhat.com, thuth@redhat.com, alex.bennee@linaro.org,
	wainersm@redhat.com
Subject: Re: [PATCH 2/2] gitlab: Add cross-riscv64-system, cross-riscv64-user
Date: Wed, 15 Sep 2021 09:32:13 -0700	[thread overview]
Message-ID: <c50f761c-1199-00d3-3016-6329c2c017ca@linaro.org> (raw)
In-Reply-To: <a3c943e1-a303-7ff8-19ab-4aef67259706@amsat.org>

On 9/15/21 8:03 AM, Philippe Mathieu-Daudé wrote:
> On 9/14/21 8:58 PM, Richard Henderson wrote:
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>   .gitlab-ci.d/crossbuilds.yml | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
>> index f10168db2e..0fe4a55ac5 100644
>> --- a/.gitlab-ci.d/crossbuilds.yml
>> +++ b/.gitlab-ci.d/crossbuilds.yml
>> @@ -124,6 +124,20 @@ cross-ppc64el-user:
>>     variables:
>>       IMAGE: debian-ppc64el-cross
>>   
>> +cross-riscv64-system:
>> +  extends: .cross_system_build_job
>> +  needs:
>> +    job: riscv64-debian-cross-container
>> +  variables:
>> +    IMAGE: debian-riscv64-cross
>> +
>> +cross-riscv64-user:
>> +  extends: .cross_user_build_job
>> +  needs:
>> +    job: riscv64-debian-cross-container
>> +  variables:
>> +    IMAGE: debian-riscv64-cross
>> +
> 
> Pending discussion on patch #1 of this series, I believe
> this job is likely going to fail, so must use the
> 'allow_failure: true' tag or something else (manual?).
> Meanwhile this is sorted out:
> NAcked-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

My only question is whether it's the image creation step that should be allowed to fail. 
If the dpkg deps weren't so broken as to not install, I *think* we should be able to rely 
on the result for the cross-build.

At least that's how I'd prefer to arrange things, if it works...

r~


  reply	other threads:[~2021-09-15 16:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 18:58 [PATCH 0/2] gitlab-ci: Add riscv64 cross builds Richard Henderson
2021-09-14 18:58 ` [PATCH 1/2] tests/docker: promote debian-riscv64-cross to a full image Richard Henderson
2021-09-15  7:35   ` Philippe Mathieu-Daudé
2021-09-15  8:15     ` Alex Bennée
2021-09-15 15:01       ` Philippe Mathieu-Daudé
2021-09-15 15:03         ` Daniel P. Berrangé
2021-09-14 18:58 ` [PATCH 2/2] gitlab: Add cross-riscv64-system, cross-riscv64-user Richard Henderson
2021-09-15  7:36   ` Philippe Mathieu-Daudé
2021-09-15 14:31   ` Willian Rampazzo
2021-09-15 15:03   ` Philippe Mathieu-Daudé
2021-09-15 16:32     ` Richard Henderson [this message]
2021-09-17 18:18       ` Philippe Mathieu-Daudé
2021-09-15  6:15 ` [PATCH 0/2] gitlab-ci: Add riscv64 cross builds Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c50f761c-1199-00d3-3016-6329c2c017ca@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).