From: Pan Nengyuan <pannengyuan@huawei.com>
To: Thomas Huth <thuth@redhat.com>
Cc: lvivier@redhat.com, pbonzini@redhat.com,
zhang.zhanghailiang@huawei.com, qemu-devel@nongnu.org
Subject: Re: [PATCH V2] vhost-user-test: fix a memory leak
Date: Wed, 15 Jan 2020 11:10:58 +0800 [thread overview]
Message-ID: <c51b9011-9add-9dc3-6fdd-266ae4f81bc9@huawei.com> (raw)
In-Reply-To: <b0a705c0-c734-c431-f8de-475c293092d2@huawei.com>
On 1/13/2020 10:32 AM, Pan Nengyuan wrote:
>
>
> On 1/12/2020 6:39 PM, Thomas Huth wrote:
>> On 10/01/2020 15.07, Thomas Huth wrote:
>>> On 20/12/2019 02.26, pannengyuan@huawei.com wrote:
>>>> From: Pan Nengyuan <pannengyuan@huawei.com>
>>>>
>>>> Spotted by ASAN.
>>>>
>>>> Reported-by: Euler Robot <euler.robot@huawei.com>
>>>> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
>>>> ---
>>>> Changes V2 to V1:
>>>> - use a "goto cleanup", instead of duplicating the "free" functions.
>>>> - free "dest_cmdline" at the end.
>>>> ---
>>>
>>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>>
>>> ... and picked up to my qtest-next tree.
>>
>> ... and now I had to unqueue the patch again. It is reproducibly causing
>> one of the gitlab CI pipelines to fail with a timeout, e.g.:
>>
>> https://gitlab.com/huth/qemu/-/jobs/400101552
>>
>> Not sure what is going on here, though, there is no obvious error
>> message in the output... this needs some more investigation... do you
>> have a gitlab account and could have a look?
>>
>
> OK, I will register a account and have a look.
>
I'm sorry, I build and test with the same params, but I can't reproduce it.
Could you add "V=1 or V=2" params to get more information ?
>> Thomas
>>
>> .
>>
next prev parent reply other threads:[~2020-01-15 3:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 1:26 [PATCH V2] vhost-user-test: fix a memory leak pannengyuan
2020-01-10 14:07 ` Thomas Huth
2020-01-12 10:39 ` Thomas Huth
2020-01-13 2:32 ` Pan Nengyuan
2020-01-15 3:10 ` Pan Nengyuan [this message]
2020-01-15 9:13 ` Thomas Huth
2020-01-16 13:29 ` Thomas Huth
2020-01-17 0:44 ` Pan Nengyuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c51b9011-9add-9dc3-6fdd-266ae4f81bc9@huawei.com \
--to=pannengyuan@huawei.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).