From: Laurent Vivier <lvivier@redhat.com>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 16/16] virtio: virtio 9p really requires CONFIG_VIRTFS to work
Date: Wed, 28 Nov 2018 21:48:04 +0100 [thread overview]
Message-ID: <c52f04d6-dced-1cb7-23b8-f301254dc366@redhat.com> (raw)
In-Reply-To: <20181126200009.862-17-quintela@redhat.com>
On 26/11/2018 21:00, Juan Quintela wrote:
> Otherwise, it has no implementation.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> default-configs/virtio.mak | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/default-configs/virtio.mak b/default-configs/virtio.mak
> index 5ae4a61018..ecb4420e74 100644
> --- a/default-configs/virtio.mak
> +++ b/default-configs/virtio.mak
> @@ -1,7 +1,7 @@
> CONFIG_VHOST_USER_SCSI=$(call land,$(CONFIG_VHOST_USER),$(CONFIG_LINUX))
> CONFIG_VHOST_USER_BLK=$(call land,$(CONFIG_VHOST_USER),$(CONFIG_LINUX))
> CONFIG_VIRTIO=y
> -CONFIG_VIRTIO_9P=y
> +CONFIG_VIRTIO_9P=$(CONFIG_VIRTFS)
> CONFIG_VIRTIO_BALLOON=y
> CONFIG_VIRTIO_BLK=y
> CONFIG_VIRTIO_CRYPTO=y
>
I think you should also replace "#ifdef CONFIG_VIRTFS" by "#ifdef
CONFIG_VIRTIO_9P" in:
hw/s390x/virtio-ccw.h
include/hw/xen/xen_backend.h
hw/xen/xen_backend.c
Thanks,
Laurent
next prev parent reply other threads:[~2018-11-28 20:48 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 19:59 [Qemu-devel] [PATCH v2 00/16] Virtio devices split from virtio-pci Juan Quintela
2018-11-26 19:59 ` [Qemu-devel] [PATCH v2 01/16] virtio: split vhost vsock bits " Juan Quintela
2018-11-28 17:33 ` Laurent Vivier
2018-11-29 6:30 ` Thomas Huth
2018-11-29 6:32 ` Thomas Huth
2018-11-30 8:56 ` Juan Quintela
2018-11-26 19:59 ` [Qemu-devel] [PATCH v2 02/16] virtio: split virtio input host " Juan Quintela
2018-11-28 18:00 ` Laurent Vivier
2018-12-12 17:43 ` Juan Quintela
2018-11-28 18:21 ` Laurent Vivier
2018-11-26 19:59 ` [Qemu-devel] [PATCH v2 03/16] virtio: split virtio input " Juan Quintela
2018-11-28 18:20 ` Laurent Vivier
2018-11-26 19:59 ` [Qemu-devel] [PATCH v2 04/16] virtio: split virtio rng " Juan Quintela
2018-11-28 20:06 ` Laurent Vivier
2018-12-12 17:43 ` Juan Quintela
2018-11-26 19:59 ` [Qemu-devel] [PATCH v2 05/16] virtio: split virtio balloon " Juan Quintela
2018-11-28 20:09 ` Laurent Vivier
2018-11-26 19:59 ` [Qemu-devel] [PATCH v2 06/16] virtio: split virtio 9p " Juan Quintela
2018-11-28 20:15 ` Laurent Vivier
2018-12-12 17:44 ` Juan Quintela
2018-11-26 20:00 ` [Qemu-devel] [PATCH v2 07/16] virtio: split vhost user blk " Juan Quintela
2018-11-28 20:21 ` Laurent Vivier
2018-11-26 20:00 ` [Qemu-devel] [PATCH v2 08/16] virtio: split vhost user scsi " Juan Quintela
2018-11-28 20:23 ` Laurent Vivier
2018-11-26 20:00 ` [Qemu-devel] [PATCH v2 09/16] virtio: split vhost " Juan Quintela
2018-11-28 20:25 ` Laurent Vivier
2018-11-26 20:00 ` [Qemu-devel] [PATCH v2 10/16] virtio: split virtio " Juan Quintela
2018-11-28 20:28 ` Laurent Vivier
2018-11-26 20:00 ` [Qemu-devel] [PATCH v2 11/16] virtio: split virtio blk bits rom virtio-pci Juan Quintela
2018-11-28 20:31 ` Laurent Vivier
2018-11-26 20:00 ` [Qemu-devel] [PATCH v2 12/16] virtio: split virtio net " Juan Quintela
2018-11-28 20:33 ` Laurent Vivier
2018-11-26 20:00 ` [Qemu-devel] [PATCH v2 13/16] virtio: split virtio serial " Juan Quintela
2018-11-28 20:36 ` Laurent Vivier
2018-11-26 20:00 ` [Qemu-devel] [PATCH v2 14/16] virtio: split virtio gpu bits rom virtio-pci.h Juan Quintela
2018-11-28 20:39 ` Laurent Vivier
2018-11-26 20:00 ` [Qemu-devel] [PATCH v2 15/16] virtio: split virtio crypto " Juan Quintela
2018-11-28 20:41 ` Laurent Vivier
2018-11-26 20:00 ` [Qemu-devel] [PATCH v2 16/16] virtio: virtio 9p really requires CONFIG_VIRTFS to work Juan Quintela
2018-11-28 20:48 ` Laurent Vivier [this message]
2018-12-13 11:44 ` Juan Quintela
2018-11-27 11:38 ` [Qemu-devel] [PATCH v2 00/16] Virtio devices split from virtio-pci Dr. David Alan Gilbert
2018-11-28 3:13 ` Michael S. Tsirkin
2018-11-28 7:46 ` Juan Quintela
2018-11-28 15:16 ` Michael S. Tsirkin
2018-11-29 13:46 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c52f04d6-dced-1cb7-23b8-f301254dc366@redhat.com \
--to=lvivier@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).