From: Thomas Huth <thuth@redhat.com>
To: "Zhao Liu" <zhao1.liu@intel.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
qemu-devel@nongnu.org
Cc: Yongwei Ma <yongwei.ma@intel.com>
Subject: Re: [PATCH 4/8] tests/unit/test-smp-parse: Use default parameters=0 when not set in -smp
Date: Wed, 12 Jun 2024 11:45:18 +0200 [thread overview]
Message-ID: <c52f6a33-8671-4ea4-bdfd-312aa5d7497e@redhat.com> (raw)
In-Reply-To: <20240529061925.350323-5-zhao1.liu@intel.com>
On 29/05/2024 08.19, Zhao Liu wrote:
> Since -smp allows parameters=1 whether the level is supported by
> machine, to avoid the test scenarios where the parameter defaults to 1
> cause some errors to be masked, explicitly set undesired parameters to
> 0.
>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> tests/unit/test-smp-parse.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-06-12 9:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 6:19 [PATCH 0/8] tests/unit/test-smp-sparse: Misc Cleanup and Add Module Test Zhao Liu
2024-05-29 6:19 ` [PATCH 1/8] tests/unit/test-smp-parse: Fix comments of drawers and books case Zhao Liu
2024-06-12 8:58 ` Thomas Huth
2024-05-29 6:19 ` [PATCH 2/8] tests/unit/test-smp-parse: Fix comment of parameters=1 case Zhao Liu
2024-06-12 9:01 ` Thomas Huth
2024-05-29 6:19 ` [PATCH 3/8] tests/unit/test-smp-parse: Fix an invalid topology case Zhao Liu
2024-06-12 9:03 ` Thomas Huth
2024-05-29 6:19 ` [PATCH 4/8] tests/unit/test-smp-parse: Use default parameters=0 when not set in -smp Zhao Liu
2024-06-12 9:45 ` Thomas Huth [this message]
2024-05-29 6:19 ` [PATCH 5/8] tests/unit/test-smp-parse: Make test cases aware of module level Zhao Liu
2024-06-12 10:01 ` Thomas Huth
2024-05-29 6:19 ` [PATCH 6/8] tests/unit/test-smp-parse: Test "modules" parameter in -smp Zhao Liu
2024-05-29 6:19 ` [PATCH 7/8] tests/unit/test-smp-parse: Test "modules" and "dies" combination case Zhao Liu
2024-05-29 6:19 ` [PATCH 8/8] tests/unit/test-smp-parse: Test the full 8-levels topology hierarchy Zhao Liu
2024-05-30 2:49 ` [PATCH 0/8] tests/unit/test-smp-sparse: Misc Cleanup and Add Module Test Ma, Yongwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c52f6a33-8671-4ea4-bdfd-312aa5d7497e@redhat.com \
--to=thuth@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=yongwei.ma@intel.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).