From: Steven Sistare <steven.sistare@oracle.com>
To: "Cédric Le Goater" <clg@redhat.com>,
"Zhenzhong Duan" <zhenzhong.duan@intel.com>,
qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, eric.auger@redhat.com,
nicolinc@nvidia.com, joao.m.martins@oracle.com,
yi.l.liu@intel.com, chao.p.peng@intel.com
Subject: Re: [PATCH] vfio: Register/unregister container for CPR only once for each container
Date: Fri, 25 Apr 2025 15:14:38 -0400 [thread overview]
Message-ID: <c5393bf7-a7a9-4f19-b738-9b94da225009@oracle.com> (raw)
In-Reply-To: <a697798e-8ce6-47da-8d77-7615486e672c@redhat.com>
On 4/25/2025 3:59 AM, Cédric Le Goater wrote:
> On 4/24/25 08:33, Zhenzhong Duan wrote:
>> vfio_cpr_register_container and vfio_cpr_unregister_container are container
>> scoped function. Calling them for each device attaching/detaching would
>> corrupt CPR reboot notifier list, i.e., when two VFIO devices are attached
>> to same container and have same notifier registered twice.
>>
>> Fixes: d9fa4223b30a ("vfio: register container for cpr")
>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
>> ---
>> btw: untested as I have no env with two migration capable devices,
>> appreciate if someone have env to help test, thanks
>>
>> hw/vfio/iommufd.c | 14 ++++++--------
>> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> Applied to vfio-next.
Looks good - steve
prev parent reply other threads:[~2025-04-25 19:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 6:33 [PATCH] vfio: Register/unregister container for CPR only once for each container Zhenzhong Duan
2025-04-24 12:14 ` Cédric Le Goater
2025-04-25 2:24 ` Duan, Zhenzhong
2025-04-25 7:59 ` Cédric Le Goater
2025-04-25 19:14 ` Steven Sistare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5393bf7-a7a9-4f19-b738-9b94da225009@oracle.com \
--to=steven.sistare@oracle.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@intel.com \
--cc=clg@redhat.com \
--cc=eric.auger@redhat.com \
--cc=joao.m.martins@oracle.com \
--cc=nicolinc@nvidia.com \
--cc=qemu-devel@nongnu.org \
--cc=yi.l.liu@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).