Re: [PATCH-for-10.1 03/12] tcg: Have tcg_gen_insn_start() take uint64_t arguments

[Richard Henderson <richard.henderson@linaro.org>]

On 3/19/25 06:44, Philippe Mathieu-Daudé wrote:
> Since restore_state_to_opc()'s rework in commits d29256896..04f105758
> and TCGContext::gen_insn_data[] widened in commit c9ad8d27caa ("tcg:
> Widen gen_insn_data to uint64_t"), tcg_set_insn_start_param()'s 3rd
> argument is uint64_t, not target_ulong. Use the same type signature
> for tcg_gen_insn_start().
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/tcg/tcg-op.h      | 7 +++----
>   accel/tcg/translate-all.c | 2 +-
>   2 files changed, 4 insertions(+), 5 deletions(-)

Your argument is flawed.  It's not that the type when extracting is different, but that 
the type when inserting is intentionally truncated to the target address size.

It's quite possible that there are no longer any odd uses, since I guess all uses of 
tcg_gen_insn_start are now in TranslatorOps.insn_start, reading from 
DisasContextBase.pc_next.  If so, I would consider changing the type here to vaddr.


r~