From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: sagark@eecs.berkeley.edu, kbastian@mail.uni-paderborn.de,
palmer@sifive.com, peer.adelt@hni.uni-paderborn.de,
Alistair.Francis@wdc.com, mjc@sifive.com
Subject: Re: [Qemu-devel] [PATCH 1/7] decodetree: Add !extern flag to argument sets
Date: Tue, 23 Oct 2018 20:40:48 +0200 [thread overview]
Message-ID: <c58275c6-93b0-e0dd-8a66-6b07f8f40f54@redhat.com> (raw)
In-Reply-To: <fc2e13a8-ee93-9a73-1c19-d9ff6576f793@linaro.org>
On 23/10/18 15:54, Richard Henderson wrote:
> On 10/23/18 2:27 PM, Philippe Mathieu-Daudé wrote:
>>> + if re_fullmatch('!extern', t):
>>> + extern = True
>>
>> It looks odd to match a negative form then use a positive one.
>>
>> Why not simply use 'extern'?
>
> "!" is an escape character here.
> Just "escape" would be a field named "escape".
>
> It follows existing similar syntax for !function=foo
Oh OK!
Thanks,
Phil.
next prev parent reply other threads:[~2018-10-23 18:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 12:04 [Qemu-devel] [PATCH 0/7] riscv decodetree followup Richard Henderson
2018-10-23 12:04 ` [Qemu-devel] [PATCH 1/7] decodetree: Add !extern flag to argument sets Richard Henderson
2018-10-23 12:56 ` Bastian Koppelmann
2018-10-23 13:27 ` Philippe Mathieu-Daudé
2018-10-23 13:54 ` Richard Henderson
2018-10-23 18:40 ` Philippe Mathieu-Daudé [this message]
2018-10-23 12:04 ` [Qemu-devel] [PATCH 2/7] decodetree: Remove "insn" argument from trans_* expanders Richard Henderson
2018-10-23 13:04 ` Bastian Koppelmann
2018-10-23 13:08 ` Richard Henderson
2018-10-23 13:25 ` Philippe Mathieu-Daudé
2018-10-23 13:25 ` Bastian Koppelmann
2018-10-23 13:56 ` Richard Henderson
2018-10-23 12:04 ` [Qemu-devel] [PATCH 3/7] target/riscv: Update for decodetree insn argument change Richard Henderson
2018-10-23 13:40 ` Bastian Koppelmann
2018-10-23 12:04 ` [Qemu-devel] [PATCH 4/7] target/riscv: Rename some argument sets in insn32.decode Richard Henderson
2018-10-23 12:21 ` Philippe Mathieu-Daudé
2018-10-23 13:03 ` Richard Henderson
2018-10-23 13:40 ` Bastian Koppelmann
2018-10-23 12:04 ` [Qemu-devel] [PATCH 5/7] target/riscv: Convert @cs_2 insns to share translation functions Richard Henderson
2018-10-23 12:26 ` Philippe Mathieu-Daudé
2018-10-23 13:04 ` Richard Henderson
2018-10-23 13:41 ` Bastian Koppelmann
2018-10-23 12:04 ` [Qemu-devel] [PATCH 6/7] target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns Richard Henderson
2018-10-23 12:27 ` Philippe Mathieu-Daudé
2018-10-23 12:04 ` [Qemu-devel] [PATCH 7/7] target/riscv: Splice decodetree inputs for riscv32 vs riscv64 Richard Henderson
2018-10-23 12:17 ` Philippe Mathieu-Daudé
2018-10-24 9:33 ` Bastian Koppelmann
2018-10-24 9:49 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c58275c6-93b0-e0dd-8a66-6b07f8f40f54@redhat.com \
--to=philmd@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=mjc@sifive.com \
--cc=palmer@sifive.com \
--cc=peer.adelt@hni.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).