From: Max Reitz <mreitz@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Mansour Ahmadi <ManSoSec@gmail.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH-for-5.0] block: Assert BlockDriver::format_name is not NULL
Date: Mon, 23 Mar 2020 14:36:32 +0100 [thread overview]
Message-ID: <c5843dbc-dd4e-ec0e-fb86-c8b0b2f2dff8@redhat.com> (raw)
In-Reply-To: <20200318222235.23856-1-philmd@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 534 bytes --]
On 18.03.20 23:22, Philippe Mathieu-Daudé wrote:
> bdrv_do_find_format() calls strcmp() using BlockDriver::format_name
> as argument, which must not be NULL. Assert this field is not null
> when we register a block driver in bdrv_register().
>
> Reported-by: Mansour Ahmadi <ManSoSec@gmail.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> block.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-03-23 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 22:22 [PATCH-for-5.0] block: Assert BlockDriver::format_name is not NULL Philippe Mathieu-Daudé
2020-03-19 11:53 ` Alberto Garcia
2020-03-23 13:36 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5843dbc-dd4e-ec0e-fb86-c8b0b2f2dff8@redhat.com \
--to=mreitz@redhat.com \
--cc=ManSoSec@gmail.com \
--cc=kwolf@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).