qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH] docs/devel/build-environment: enhance MSYS2 instructions
Date: Wed, 30 Apr 2025 11:12:28 -0700	[thread overview]
Message-ID: <c5bd354b-15e9-4f44-b768-8d2ded4d0e5a@linaro.org> (raw)
In-Reply-To: <82b79386-ee34-4f06-8e61-76f47b4aaad7@redhat.com>

On 4/30/25 10:54 AM, Thomas Huth wrote:
> On 30/04/2025 16.34, Pierrick Bouvier wrote:
>> On 4/30/25 3:09 AM, Thomas Huth wrote:
>>> On 28/04/2025 21.35, Pierrick Bouvier wrote:
>>>> On 3/24/25 10:47 AM, Pierrick Bouvier wrote:
>>>>> On 3/5/25 13:38, Pierrick Bouvier wrote:
>>>>>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>>>>>> ---
>>>>>>      docs/devel/build-environment.rst | 4 ++--
>>>>>>      1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/docs/devel/build-environment.rst b/docs/devel/build-
>>>>>> environment.rst
>>>>>> index f133ef2e012..661f6ea8504 100644
>>>>>> --- a/docs/devel/build-environment.rst
>>>>>> +++ b/docs/devel/build-environment.rst
>>>>>> @@ -97,11 +97,11 @@ build QEMU in MSYS2 itself.
>>>>>>      ::
>>>>>> -    pacman -S wget
>>>>>> +    pacman -S wget base-devel git
>>>>>>          wget https://raw.githubusercontent.com/msys2/MINGW-packages/refs/
>>>>>> heads/master/mingw-w64-qemu/PKGBUILD
>>>>>>          # Some packages may be missing for your environment, installation
>>>>>> will still
>>>>>>          # be done though.
>>>>>> -    makepkg -s PKGBUILD || true
>>>>>> +    makepkg --syncdeps --nobuild PKGBUILD || true
>>>>>>      Build on windows-aarch64
>>>>>>      ++++++++++++++++++++++++
>>>>>
>>>>> Gentle ping on this trivial change for doc.
>>>>>
>>>>
>>>> Another gentle ping on this trivial doc change.
>>>
>>> Not really my turf, I don't have much clue about the MSYS2 environment, but
>>> since there were no objections, I can add it to my next PR.
>>>
>>
>> Thank you, that's appreciated.
> 
> Could you still please provide a proper patch description, as Daniel suggested?
>

Sure.
I just sent v2: 20250430181047.2043492-1-pierrick.bouvier@linaro.org

>    Thanks,
>     Thomas
> 

Thanks,
Pierrick


  reply	other threads:[~2025-04-30 18:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-05 21:38 [PATCH] docs/devel/build-environment: enhance MSYS2 instructions Pierrick Bouvier
2025-03-24 17:47 ` Pierrick Bouvier
2025-04-28 19:35   ` Pierrick Bouvier
2025-04-30 10:09     ` Thomas Huth
2025-04-30 14:34       ` Pierrick Bouvier
2025-04-30 17:54         ` Thomas Huth
2025-04-30 18:12           ` Pierrick Bouvier [this message]
2025-03-24 18:54 ` Philippe Mathieu-Daudé
2025-04-30 10:34 ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5bd354b-15e9-4f44-b768-8d2ded4d0e5a@linaro.org \
    --to=pierrick.bouvier@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).