From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgB6g-0006NI-Km for qemu-devel@nongnu.org; Fri, 11 Aug 2017 10:40:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgB6d-0000lM-C7 for qemu-devel@nongnu.org; Fri, 11 Aug 2017 10:40:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33314) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dgB6d-0000jX-3X for qemu-devel@nongnu.org; Fri, 11 Aug 2017 10:40:07 -0400 References: <20170811074652.31474-1-david@redhat.com> <20170811074652.31474-2-david@redhat.com> <79f9f850-f0dc-cea7-8a5c-85d23b07842b@redhat.com> From: Thomas Huth Message-ID: Date: Fri, 11 Aug 2017 16:39:59 +0200 MIME-Version: 1.0 In-Reply-To: <79f9f850-f0dc-cea7-8a5c-85d23b07842b@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , qemu-devel@nongnu.org Cc: rth@twiddle.net, Aurelien Jarno , cohuck@redhat.com, borntraeger@de.ibm.com On 11.08.2017 16:21, David Hildenbrand wrote: > On 11.08.2017 16:00, Thomas Huth wrote: >> On 11.08.2017 09:46, David Hildenbrand wrote: >>> cpu.h should only contain what really has to be accessed outside of >>> target/s390x/. Add internal.h which can only be used inside target/s390x/. >>> >>> Move everything that isn't fast enough to run away and restructure it >>> right away. >>> >>> Minor style fixes to avoid checkpatch warning to: >>> - struct Lowcore: "{" goes into same line as typedef >>> - struct LowCore: add spaces around "-" in array length calculations >>> - time2tod() and tod2time(): move "{" to separate line >>> - get_per_atmid(): add space between ")" and "?". Move cases by one char. >>> - get_per_atmid(): drop extra paremthesis around (1 << 6) >>> >>> Signed-off-by: David Hildenbrand >>> --- >> [...] >>> diff --git a/target/s390x/internal.h b/target/s390x/internal.h >>> new file mode 100644 >>> index 0000000..9a55271 >>> --- /dev/null >>> +++ b/target/s390x/internal.h >>> @@ -0,0 +1,560 @@ >>> +/* >>> + * s390x internal definitions and helpers >>> + * >>> + * Copyright (c) 2009 Ulrich Hecht >>> + * >>> + * This library is free software; you can redistribute it and/or >>> + * modify it under the terms of the GNU Lesser General Public >>> + * License as published by the Free Software Foundation; either >>> + * version 2 of the License, or (at your option) any later version. >>> + * >>> + * This library is distributed in the hope that it will be useful, >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >>> + * Lesser General Public License for more details. >>> + * >>> + * Contributions after 2012-10-29 are licensed under the terms of the >>> + * GNU GPL, version 2 or (at your option) any later version. >> >> Slightly off-topic to your patch, but since you're at it anyway: AFAIK >> the above sentence effectively means that we should update the copyright >> boiler plate to GPL2+ nowadays. See >> https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html section 3. > > (not a license expert) > > Do you want me to replace it also in cpu.h? No, at least not directly here in this patch series. I think that's something for a separate patch (we've got the same issue in cpu.c and kvm.c), so just use the correct boilerplate text in internal.h here. > Do we still need the remark about "contributions after 2012-10-29 are" ? Once the license text has been updated, the remark can certainly go away. Thomas