From: Maxim Levitsky <mlevitsk@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
integration@gluster.org, sheepdog@lists.wpkg.org,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org, Jeff Cody <codyprime@gmail.com>,
Stefan Weil <sw@weilnetz.de>, Peter Lieven <pl@kamp.de>,
"Richard W.M. Jones" <rjones@redhat.com>,
Max Reitz <mreitz@redhat.com>, "Denis V. Lunev" <den@openvz.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Liu Yuan <namei.unix@gmail.com>,
Jason Dillaman <dillaman@redhat.com>
Subject: Re: [PATCH 1/2] block: pass BlockDriver reference to the .bdrv_co_create
Date: Thu, 26 Mar 2020 15:22:01 +0200 [thread overview]
Message-ID: <c5d0b9889dd7644377464838fbcd58fedcdd93dc.camel@redhat.com> (raw)
In-Reply-To: <af808169-5dcb-6293-3c8a-00ab0a9cd76e@redhat.com>
On Thu, 2020-03-26 at 08:18 -0500, Eric Blake wrote:
> On 3/25/20 8:12 PM, Maxim Levitsky wrote:
> > This will allow to reuse a single generic .bdrv_co_create
>
> "allow to ${verb}" is not idiomatic, better is "allow ${subject} to
> ${verb}" or "allow ${verb}ing". In this case, I'd go with:
>
> This will allow the reuse of a single...
I agree! This commit will probably go as is but next time I'll keep it in mind!
Best regards,
Maxim Levitsky
>
> > implementation for several drivers.
> > No functional changes.
> >
> > Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> > ---
next prev parent reply other threads:[~2020-03-26 13:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 1:12 [PATCH 0/2] Fix the generic image creation code Maxim Levitsky
2020-03-26 1:12 ` [PATCH 1/2] block: pass BlockDriver reference to the .bdrv_co_create Maxim Levitsky
2020-03-26 13:18 ` Eric Blake
2020-03-26 13:22 ` Maxim Levitsky [this message]
2020-03-26 13:27 ` Eric Blake
2020-03-26 1:12 ` [PATCH 2/2] block: trickle down the fallback image creation function use to the block drivers Maxim Levitsky
2020-03-26 11:20 ` Max Reitz
2020-03-26 13:20 ` Eric Blake
2020-03-26 13:28 ` Kevin Wolf
2020-03-26 13:35 ` Eric Blake
2020-03-26 13:39 ` Max Reitz
2020-03-26 13:30 ` Maxim Levitsky
2020-03-26 10:55 ` [PATCH 0/2] Fix the generic image creation code Denis V. Lunev
2020-03-26 12:23 ` Max Reitz
2020-03-26 13:38 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5d0b9889dd7644377464838fbcd58fedcdd93dc.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=codyprime@gmail.com \
--cc=den@openvz.org \
--cc=dillaman@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=integration@gluster.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=namei.unix@gmail.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=ronniesahlberg@gmail.com \
--cc=sheepdog@lists.wpkg.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).