From: Eric Blake <eblake@redhat.com>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2] softfloat: rename make_float[x80|128]_init to const_float[x80|128]
Date: Tue, 19 Sep 2017 16:18:16 -0500 [thread overview]
Message-ID: <c5e9a983-6543-28d3-8e4c-c49b2ac1b694@redhat.com> (raw)
In-Reply-To: <20170919211012.13507-1-laurent@vivier.eu>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On 09/19/2017 04:10 PM, Laurent Vivier wrote:
> We already have const_float16(), const_float32() and const_float64(),
> so rename make_floatx80_init() and make_float128_init() as
s/as/to now be/
> const_floatx80() and const_float128().
s/\./, for consistency./
>
> Redefine make_float16(), make_float32() and make_float64() as
s/as/to be like/
> make_floatx80() and make_float128() using a cast.
s/ using a cast/, by using a compound literal/
I almost wonder if splitting this patch into two parts makes more sense
(one for the renaming of make_float[x80,128]_init, the other for the
rewriting of make_float[16,32,64] from gcc extension to compound literal).
At any rate, the code itself looks fine.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-09-19 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 21:10 [Qemu-devel] [PATCH v2] softfloat: rename make_float[x80|128]_init to const_float[x80|128] Laurent Vivier
2017-09-19 21:18 ` Eric Blake [this message]
2017-09-20 13:12 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5e9a983-6543-28d3-8e4c-c49b2ac1b694@redhat.com \
--to=eblake@redhat.com \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).