* [Qemu-devel] [PATCH v2] softfloat: rename make_float[x80|128]_init to const_float[x80|128]
@ 2017-09-19 21:10 Laurent Vivier
2017-09-19 21:18 ` Eric Blake
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Vivier @ 2017-09-19 21:10 UTC (permalink / raw)
To: qemu-devel
Cc: Eric Blake, Richard Henderson, Aurelien Jarno,
Philippe Mathieu-Daudé, Peter Maydell, Laurent Vivier
We already have const_float16(), const_float32() and const_float64(),
so rename make_floatx80_init() and make_float128_init() as
const_floatx80() and const_float128().
Redefine make_float16(), make_float32() and make_float64() as
make_floatx80() and make_float128() using a cast.
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
v2: change float16(), make_float32() and make_float64()
instead of make_floatx80() and make_float128()
include/fpu/softfloat.h | 10 +++++-----
target/m68k/fpu_helper.c | 44 ++++++++++++++++++++++----------------------
2 files changed, 27 insertions(+), 27 deletions(-)
diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h
index 0f96a0edd1..cda6421b23 100644
--- a/include/fpu/softfloat.h
+++ b/include/fpu/softfloat.h
@@ -113,20 +113,20 @@ typedef struct {
uint16_t v;
} float16;
#define float16_val(x) (((float16)(x)).v)
-#define make_float16(x) __extension__ ({ float16 f16_val = {x}; f16_val; })
+#define make_float16(x) ((float16) { x })
#define const_float16(x) { x }
typedef struct {
uint32_t v;
} float32;
/* The cast ensures an error if the wrong type is passed. */
#define float32_val(x) (((float32)(x)).v)
-#define make_float32(x) __extension__ ({ float32 f32_val = {x}; f32_val; })
+#define make_float32(x) ((float32) { x })
#define const_float32(x) { x }
typedef struct {
uint64_t v;
} float64;
#define float64_val(x) (((float64)(x)).v)
-#define make_float64(x) __extension__ ({ float64 f64_val = {x}; f64_val; })
+#define make_float64(x) ((float64) { x })
#define const_float64(x) { x }
#else
typedef uint16_t float16;
@@ -147,7 +147,7 @@ typedef struct {
uint16_t high;
} floatx80;
#define make_floatx80(exp, mant) ((floatx80) { mant, exp })
-#define make_floatx80_init(exp, mant) { .low = mant, .high = exp }
+#define const_floatx80(exp, mant) { .low = mant, .high = exp }
typedef struct {
#ifdef HOST_WORDS_BIGENDIAN
uint64_t high, low;
@@ -156,7 +156,7 @@ typedef struct {
#endif
} float128;
#define make_float128(high_, low_) ((float128) { .high = high_, .low = low_ })
-#define make_float128_init(high_, low_) { .high = high_, .low = low_ }
+#define const_float128(high_, low_) { .high = high_, .low = low_ }
/*----------------------------------------------------------------------------
| Software IEC/IEEE floating-point underflow tininess-detection mode.
diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.c
index 665e7609af..bf62cf8003 100644
--- a/target/m68k/fpu_helper.c
+++ b/target/m68k/fpu_helper.c
@@ -29,28 +29,28 @@
*/
static const floatx80 fpu_rom[128] = {
- [0x00] = make_floatx80_init(0x4000, 0xc90fdaa22168c235ULL), /* Pi */
- [0x0b] = make_floatx80_init(0x3ffd, 0x9a209a84fbcff798ULL), /* Log10(2) */
- [0x0c] = make_floatx80_init(0x4000, 0xadf85458a2bb4a9aULL), /* e */
- [0x0d] = make_floatx80_init(0x3fff, 0xb8aa3b295c17f0bcULL), /* Log2(e) */
- [0x0e] = make_floatx80_init(0x3ffd, 0xde5bd8a937287195ULL), /* Log10(e) */
- [0x0f] = make_floatx80_init(0x0000, 0x0000000000000000ULL), /* Zero */
- [0x30] = make_floatx80_init(0x3ffe, 0xb17217f7d1cf79acULL), /* ln(2) */
- [0x31] = make_floatx80_init(0x4000, 0x935d8dddaaa8ac17ULL), /* ln(10) */
- [0x32] = make_floatx80_init(0x3fff, 0x8000000000000000ULL), /* 10^0 */
- [0x33] = make_floatx80_init(0x4002, 0xa000000000000000ULL), /* 10^1 */
- [0x34] = make_floatx80_init(0x4005, 0xc800000000000000ULL), /* 10^2 */
- [0x35] = make_floatx80_init(0x400c, 0x9c40000000000000ULL), /* 10^4 */
- [0x36] = make_floatx80_init(0x4019, 0xbebc200000000000ULL), /* 10^8 */
- [0x37] = make_floatx80_init(0x4034, 0x8e1bc9bf04000000ULL), /* 10^16 */
- [0x38] = make_floatx80_init(0x4069, 0x9dc5ada82b70b59eULL), /* 10^32 */
- [0x39] = make_floatx80_init(0x40d3, 0xc2781f49ffcfa6d5ULL), /* 10^64 */
- [0x3a] = make_floatx80_init(0x41a8, 0x93ba47c980e98ce0ULL), /* 10^128 */
- [0x3b] = make_floatx80_init(0x4351, 0xaa7eebfb9df9de8eULL), /* 10^256 */
- [0x3c] = make_floatx80_init(0x46a3, 0xe319a0aea60e91c7ULL), /* 10^512 */
- [0x3d] = make_floatx80_init(0x4d48, 0xc976758681750c17ULL), /* 10^1024 */
- [0x3e] = make_floatx80_init(0x5a92, 0x9e8b3b5dc53d5de5ULL), /* 10^2048 */
- [0x3f] = make_floatx80_init(0x7525, 0xc46052028a20979bULL), /* 10^4096 */
+ [0x00] = const_floatx80(0x4000, 0xc90fdaa22168c235ULL), /* Pi */
+ [0x0b] = const_floatx80(0x3ffd, 0x9a209a84fbcff798ULL), /* Log10(2) */
+ [0x0c] = const_floatx80(0x4000, 0xadf85458a2bb4a9aULL), /* e */
+ [0x0d] = const_floatx80(0x3fff, 0xb8aa3b295c17f0bcULL), /* Log2(e) */
+ [0x0e] = const_floatx80(0x3ffd, 0xde5bd8a937287195ULL), /* Log10(e) */
+ [0x0f] = const_floatx80(0x0000, 0x0000000000000000ULL), /* Zero */
+ [0x30] = const_floatx80(0x3ffe, 0xb17217f7d1cf79acULL), /* ln(2) */
+ [0x31] = const_floatx80(0x4000, 0x935d8dddaaa8ac17ULL), /* ln(10) */
+ [0x32] = const_floatx80(0x3fff, 0x8000000000000000ULL), /* 10^0 */
+ [0x33] = const_floatx80(0x4002, 0xa000000000000000ULL), /* 10^1 */
+ [0x34] = const_floatx80(0x4005, 0xc800000000000000ULL), /* 10^2 */
+ [0x35] = const_floatx80(0x400c, 0x9c40000000000000ULL), /* 10^4 */
+ [0x36] = const_floatx80(0x4019, 0xbebc200000000000ULL), /* 10^8 */
+ [0x37] = const_floatx80(0x4034, 0x8e1bc9bf04000000ULL), /* 10^16 */
+ [0x38] = const_floatx80(0x4069, 0x9dc5ada82b70b59eULL), /* 10^32 */
+ [0x39] = const_floatx80(0x40d3, 0xc2781f49ffcfa6d5ULL), /* 10^64 */
+ [0x3a] = const_floatx80(0x41a8, 0x93ba47c980e98ce0ULL), /* 10^128 */
+ [0x3b] = const_floatx80(0x4351, 0xaa7eebfb9df9de8eULL), /* 10^256 */
+ [0x3c] = const_floatx80(0x46a3, 0xe319a0aea60e91c7ULL), /* 10^512 */
+ [0x3d] = const_floatx80(0x4d48, 0xc976758681750c17ULL), /* 10^1024 */
+ [0x3e] = const_floatx80(0x5a92, 0x9e8b3b5dc53d5de5ULL), /* 10^2048 */
+ [0x3f] = const_floatx80(0x7525, 0xc46052028a20979bULL), /* 10^4096 */
};
int32_t HELPER(reds32)(CPUM68KState *env, FPReg *val)
--
2.13.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] softfloat: rename make_float[x80|128]_init to const_float[x80|128]
2017-09-19 21:10 [Qemu-devel] [PATCH v2] softfloat: rename make_float[x80|128]_init to const_float[x80|128] Laurent Vivier
@ 2017-09-19 21:18 ` Eric Blake
2017-09-20 13:12 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Eric Blake @ 2017-09-19 21:18 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel
Cc: Richard Henderson, Aurelien Jarno, Philippe Mathieu-Daudé,
Peter Maydell
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On 09/19/2017 04:10 PM, Laurent Vivier wrote:
> We already have const_float16(), const_float32() and const_float64(),
> so rename make_floatx80_init() and make_float128_init() as
s/as/to now be/
> const_floatx80() and const_float128().
s/\./, for consistency./
>
> Redefine make_float16(), make_float32() and make_float64() as
s/as/to be like/
> make_floatx80() and make_float128() using a cast.
s/ using a cast/, by using a compound literal/
I almost wonder if splitting this patch into two parts makes more sense
(one for the renaming of make_float[x80,128]_init, the other for the
rewriting of make_float[16,32,64] from gcc extension to compound literal).
At any rate, the code itself looks fine.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] softfloat: rename make_float[x80|128]_init to const_float[x80|128]
2017-09-19 21:18 ` Eric Blake
@ 2017-09-20 13:12 ` Richard Henderson
0 siblings, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2017-09-20 13:12 UTC (permalink / raw)
To: Eric Blake, Laurent Vivier, qemu-devel
Cc: Aurelien Jarno, Philippe Mathieu-Daudé, Peter Maydell
On 09/19/2017 04:18 PM, Eric Blake wrote:
> On 09/19/2017 04:10 PM, Laurent Vivier wrote:
>> We already have const_float16(), const_float32() and const_float64(),
>> so rename make_floatx80_init() and make_float128_init() as
>
> s/as/to now be/
>
>> const_floatx80() and const_float128().
>
> s/\./, for consistency./
>
>>
>> Redefine make_float16(), make_float32() and make_float64() as
>
> s/as/to be like/
>
>> make_floatx80() and make_float128() using a cast.
>
> s/ using a cast/, by using a compound literal/
I was about to make the same quibble.
> I almost wonder if splitting this patch into two parts makes more sense
> (one for the renaming of make_float[x80,128]_init, the other for the
> rewriting of make_float[16,32,64] from gcc extension to compound literal).
I think the patch is fine as-is.
Fix the patch description and I'll give it
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-20 13:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-19 21:10 [Qemu-devel] [PATCH v2] softfloat: rename make_float[x80|128]_init to const_float[x80|128] Laurent Vivier
2017-09-19 21:18 ` Eric Blake
2017-09-20 13:12 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).