* [Qemu-devel] [PATCH] vl: Avoid crash when -mon is underspecified
@ 2018-10-23 21:35 Eric Blake
2018-10-23 21:37 ` Paolo Bonzini
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Eric Blake @ 2018-10-23 21:35 UTC (permalink / raw)
To: qemu-devel; +Cc: peterx, armbru, marcandre.lureau, Paolo Bonzini
A quick coredump on an incomplete command line:
./x86_64-softmmu/qemu-system-x86_64 -mon mode=control,pretty=on
#0 0x00007ffff723d9e4 in g_str_hash () at /lib64/libglib-2.0.so.0
#1 0x00007ffff723ce38 in g_hash_table_lookup () at /lib64/libglib-2.0.so.0
#2 0x0000555555cc0073 in object_class_property_find (klass=0x5555566a94b0, name=0x0, errp=0x0) at qom/object.c:1135
#3 0x0000555555cc004b in object_class_property_find (klass=0x5555566a9440, name=0x0, errp=0x0) at qom/object.c:1129
#4 0x0000555555cbfe6e in object_property_find (obj=0x5555568348c0, name=0x0, errp=0x0) at qom/object.c:1080
#5 0x0000555555cc183d in object_resolve_path_component (parent=0x5555568348c0, part=0x0) at qom/object.c:1762
#6 0x0000555555d82071 in qemu_chr_find (name=0x0) at chardev/char.c:802
#7 0x00005555559d77cb in mon_init_func (opaque=0x0, opts=0x5555566b65a0, errp=0x0) at vl.c:2291
Fix it to instead fail gracefully.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
vl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/vl.c b/vl.c
index 4e25c78bff0..2ed8672eb79 100644
--- a/vl.c
+++ b/vl.c
@@ -2288,6 +2288,10 @@ static int mon_init_func(void *opaque, QemuOpts *opts, Error **errp)
}
chardev = qemu_opt_get(opts, "chardev");
+ if (!chardev) {
+ error_report("chardev is required");
+ exit(1);
+ }
chr = qemu_chr_find(chardev);
if (chr == NULL) {
error_report("chardev \"%s\" not found", chardev);
--
2.17.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vl: Avoid crash when -mon is underspecified
2018-10-23 21:35 [Qemu-devel] [PATCH] vl: Avoid crash when -mon is underspecified Eric Blake
@ 2018-10-23 21:37 ` Paolo Bonzini
2018-10-24 10:58 ` Philippe Mathieu-Daudé
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2018-10-23 21:37 UTC (permalink / raw)
To: Eric Blake, qemu-devel; +Cc: peterx, armbru, marcandre.lureau
On 23/10/2018 23:35, Eric Blake wrote:
> A quick coredump on an incomplete command line:
> ./x86_64-softmmu/qemu-system-x86_64 -mon mode=control,pretty=on
>
> #0 0x00007ffff723d9e4 in g_str_hash () at /lib64/libglib-2.0.so.0
> #1 0x00007ffff723ce38 in g_hash_table_lookup () at /lib64/libglib-2.0.so.0
> #2 0x0000555555cc0073 in object_class_property_find (klass=0x5555566a94b0, name=0x0, errp=0x0) at qom/object.c:1135
> #3 0x0000555555cc004b in object_class_property_find (klass=0x5555566a9440, name=0x0, errp=0x0) at qom/object.c:1129
> #4 0x0000555555cbfe6e in object_property_find (obj=0x5555568348c0, name=0x0, errp=0x0) at qom/object.c:1080
> #5 0x0000555555cc183d in object_resolve_path_component (parent=0x5555568348c0, part=0x0) at qom/object.c:1762
> #6 0x0000555555d82071 in qemu_chr_find (name=0x0) at chardev/char.c:802
> #7 0x00005555559d77cb in mon_init_func (opaque=0x0, opts=0x5555566b65a0, errp=0x0) at vl.c:2291
>
> Fix it to instead fail gracefully.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> vl.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 4e25c78bff0..2ed8672eb79 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2288,6 +2288,10 @@ static int mon_init_func(void *opaque, QemuOpts *opts, Error **errp)
> }
>
> chardev = qemu_opt_get(opts, "chardev");
> + if (!chardev) {
> + error_report("chardev is required");
> + exit(1);
> + }
> chr = qemu_chr_find(chardev);
> if (chr == NULL) {
> error_report("chardev \"%s\" not found", chardev);
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vl: Avoid crash when -mon is underspecified
2018-10-23 21:35 [Qemu-devel] [PATCH] vl: Avoid crash when -mon is underspecified Eric Blake
2018-10-23 21:37 ` Paolo Bonzini
@ 2018-10-24 10:58 ` Philippe Mathieu-Daudé
2018-10-24 11:32 ` Peter Xu
2018-10-30 16:36 ` Markus Armbruster
3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-10-24 10:58 UTC (permalink / raw)
To: Eric Blake, qemu-devel; +Cc: marcandre.lureau, armbru, peterx, Paolo Bonzini
On 23/10/18 23:35, Eric Blake wrote:
> A quick coredump on an incomplete command line:
> ./x86_64-softmmu/qemu-system-x86_64 -mon mode=control,pretty=on
>
> #0 0x00007ffff723d9e4 in g_str_hash () at /lib64/libglib-2.0.so.0
> #1 0x00007ffff723ce38 in g_hash_table_lookup () at /lib64/libglib-2.0.so.0
> #2 0x0000555555cc0073 in object_class_property_find (klass=0x5555566a94b0, name=0x0, errp=0x0) at qom/object.c:1135
> #3 0x0000555555cc004b in object_class_property_find (klass=0x5555566a9440, name=0x0, errp=0x0) at qom/object.c:1129
> #4 0x0000555555cbfe6e in object_property_find (obj=0x5555568348c0, name=0x0, errp=0x0) at qom/object.c:1080
> #5 0x0000555555cc183d in object_resolve_path_component (parent=0x5555568348c0, part=0x0) at qom/object.c:1762
> #6 0x0000555555d82071 in qemu_chr_find (name=0x0) at chardev/char.c:802
> #7 0x00005555559d77cb in mon_init_func (opaque=0x0, opts=0x5555566b65a0, errp=0x0) at vl.c:2291
>
> Fix it to instead fail gracefully.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> vl.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 4e25c78bff0..2ed8672eb79 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2288,6 +2288,10 @@ static int mon_init_func(void *opaque, QemuOpts *opts, Error **errp)
> }
>
> chardev = qemu_opt_get(opts, "chardev");
> + if (!chardev) {
> + error_report("chardev is required");
> + exit(1);
> + }
> chr = qemu_chr_find(chardev);
> if (chr == NULL) {
> error_report("chardev \"%s\" not found", chardev);
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vl: Avoid crash when -mon is underspecified
2018-10-23 21:35 [Qemu-devel] [PATCH] vl: Avoid crash when -mon is underspecified Eric Blake
2018-10-23 21:37 ` Paolo Bonzini
2018-10-24 10:58 ` Philippe Mathieu-Daudé
@ 2018-10-24 11:32 ` Peter Xu
2018-10-30 16:36 ` Markus Armbruster
3 siblings, 0 replies; 5+ messages in thread
From: Peter Xu @ 2018-10-24 11:32 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, armbru, marcandre.lureau, Paolo Bonzini
On Tue, Oct 23, 2018 at 10:35:59PM +0100, Eric Blake wrote:
> A quick coredump on an incomplete command line:
> ./x86_64-softmmu/qemu-system-x86_64 -mon mode=control,pretty=on
>
> #0 0x00007ffff723d9e4 in g_str_hash () at /lib64/libglib-2.0.so.0
> #1 0x00007ffff723ce38 in g_hash_table_lookup () at /lib64/libglib-2.0.so.0
> #2 0x0000555555cc0073 in object_class_property_find (klass=0x5555566a94b0, name=0x0, errp=0x0) at qom/object.c:1135
> #3 0x0000555555cc004b in object_class_property_find (klass=0x5555566a9440, name=0x0, errp=0x0) at qom/object.c:1129
> #4 0x0000555555cbfe6e in object_property_find (obj=0x5555568348c0, name=0x0, errp=0x0) at qom/object.c:1080
> #5 0x0000555555cc183d in object_resolve_path_component (parent=0x5555568348c0, part=0x0) at qom/object.c:1762
> #6 0x0000555555d82071 in qemu_chr_find (name=0x0) at chardev/char.c:802
> #7 0x00005555559d77cb in mon_init_func (opaque=0x0, opts=0x5555566b65a0, errp=0x0) at vl.c:2291
>
> Fix it to instead fail gracefully.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vl: Avoid crash when -mon is underspecified
2018-10-23 21:35 [Qemu-devel] [PATCH] vl: Avoid crash when -mon is underspecified Eric Blake
` (2 preceding siblings ...)
2018-10-24 11:32 ` Peter Xu
@ 2018-10-30 16:36 ` Markus Armbruster
3 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2018-10-30 16:36 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, marcandre.lureau, peterx, Paolo Bonzini
Eric Blake <eblake@redhat.com> writes:
> A quick coredump on an incomplete command line:
> ./x86_64-softmmu/qemu-system-x86_64 -mon mode=control,pretty=on
>
> #0 0x00007ffff723d9e4 in g_str_hash () at /lib64/libglib-2.0.so.0
> #1 0x00007ffff723ce38 in g_hash_table_lookup () at /lib64/libglib-2.0.so.0
> #2 0x0000555555cc0073 in object_class_property_find (klass=0x5555566a94b0, name=0x0, errp=0x0) at qom/object.c:1135
> #3 0x0000555555cc004b in object_class_property_find (klass=0x5555566a9440, name=0x0, errp=0x0) at qom/object.c:1129
> #4 0x0000555555cbfe6e in object_property_find (obj=0x5555568348c0, name=0x0, errp=0x0) at qom/object.c:1080
> #5 0x0000555555cc183d in object_resolve_path_component (parent=0x5555568348c0, part=0x0) at qom/object.c:1762
> #6 0x0000555555d82071 in qemu_chr_find (name=0x0) at chardev/char.c:802
> #7 0x00005555559d77cb in mon_init_func (opaque=0x0, opts=0x5555566b65a0, errp=0x0) at vl.c:2291
>
> Fix it to instead fail gracefully.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Queued. Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-30 16:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-23 21:35 [Qemu-devel] [PATCH] vl: Avoid crash when -mon is underspecified Eric Blake
2018-10-23 21:37 ` Paolo Bonzini
2018-10-24 10:58 ` Philippe Mathieu-Daudé
2018-10-24 11:32 ` Peter Xu
2018-10-30 16:36 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).