From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DECDC433EF for ; Mon, 1 Nov 2021 13:42:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA26B60E78 for ; Mon, 1 Nov 2021 13:42:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AA26B60E78 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:60086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhXZl-0005Fh-IB for qemu-devel@archiver.kernel.org; Mon, 01 Nov 2021 09:42:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhXYs-0004T0-CQ for qemu-devel@nongnu.org; Mon, 01 Nov 2021 09:41:18 -0400 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]:42621) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhXYq-00038n-8m for qemu-devel@nongnu.org; Mon, 01 Nov 2021 09:41:18 -0400 Received: by mail-qk1-x733.google.com with SMTP id bm28so1393522qkb.9 for ; Mon, 01 Nov 2021 06:41:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ytVacYDiCdrCtL3ustDwdulgynqknFF/M71BAuL39t0=; b=tcqJH2uQjRSE2vSngazv5UwPpKejyYV73h1eJOQsFrhf6vfF+0AixHU6jkx0vSFGbO so0J0XcvCEq8Z/l8aAlucHoEqzHXk8cIxb3WNV4h10HjNkoy3JbRFvP4MCsUApR6LjWS AS626Fnytf0dbSEUMEDoUBhbPhf/YkZiolhLP72p0X+uM8kQ4mdQsaSvmz0JI/WuM9DY 0IVDYvb/8VwyWuRdsbV8iMs+iIEz5GeoG2n53HAZQEEseK7hX7u4baCoPuzIVUQkVsvX QGhgeDqTsgiJxUaMGQ3zHUoSzvOKWVQfErmuS8HCe9F1NumHl1fver2XqiBWSHa8V8KO dCZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ytVacYDiCdrCtL3ustDwdulgynqknFF/M71BAuL39t0=; b=DqGtpPFaPc3vwkXv66Fdm4w/gcwh1Hq19ARIUjYfkl4OI+UpBN43VIYFs/eLpLeOeF Fhn6NZ9oCy62xEGfcl1VNEbCrQzuHB+ICMNw8YRzvPI2S2YmAtVTyH1SFa6H4KGIZYD7 PwdqYvBVqYy+lE6BjcgyRmlIAV3dcpivMbgJWOWR8crscHAdZUP0pJqex55WBfxaY62X JqFvAF3wGqYAjHGxniptthL7C7UUJPi6V4MHQW40CFfil7byPeew9P1xafUJC+K743Nw jTFZGiOdcMl2bANVPA2qdl55F+laYyjuQHHBULRiYxXrAhRr6PcwfWSp+k0l/kTEcN9b ap/Q== X-Gm-Message-State: AOAM532VQPPSA+irEeUHxfeJ1w44rYezilLG/288cUg8KlB+/A6OCFQa fkDnUWBEnBguaZnLhtIFNTcrjg== X-Google-Smtp-Source: ABdhPJwAqU2RmxEUsqiWLoADuCRd4sQCeBihX7vKCBDRKgNv9i8CRktenDTv6gLSxRtvJSg0FwBjRg== X-Received: by 2002:ae9:e108:: with SMTP id g8mr22520058qkm.98.1635774074487; Mon, 01 Nov 2021 06:41:14 -0700 (PDT) Received: from [172.20.81.179] (rrcs-172-254-253-57.nyc.biz.rr.com. [172.254.253.57]) by smtp.gmail.com with ESMTPSA id k14sm10465025qko.120.2021.11.01.06.41.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Nov 2021 06:41:14 -0700 (PDT) Subject: Re: [PATCH 08/13] target/riscv: Fix check range for first fault only To: LIU Zhiwei , qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20211101100143.44356-1-zhiwei_liu@c-sky.com> <20211101100143.44356-9-zhiwei_liu@c-sky.com> From: Richard Henderson Message-ID: Date: Mon, 1 Nov 2021 09:41:12 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211101100143.44356-9-zhiwei_liu@c-sky.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::733; envelope-from=richard.henderson@linaro.org; helo=mail-qk1-x733.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.14, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: palmer@dabbelt.com, bin.meng@windriver.com, Alistair.Francis@wdc.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/1/21 6:01 AM, LIU Zhiwei wrote: > Only check the range that has passed the address translation. > > Signed-off-by: LIU Zhiwei > --- > target/riscv/vector_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson > @@ -638,12 +638,12 @@ vext_ldff(void *vd, void *v0, target_ulong base, > cpu_mmu_index(env, false)); > if (host) { > #ifdef CONFIG_USER_ONLY > - if (page_check_range(addr, nf * msz, PAGE_READ) < 0) { > + if (page_check_range(addr, offset, PAGE_READ) < 0) { > vl = i; > goto ProbeSuccess; > } > #else > - probe_pages(env, addr, nf * msz, ra, MMU_DATA_LOAD); > + probe_pages(env, addr, offset, ra, MMU_DATA_LOAD); > #endif It looks like we could lose the ifdef here and always use probe_pages. But that of course is a different change. r~