From: Eric Blake <eblake@redhat.com>
To: Yi Min Zhao <zyimin@linux.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] sandbox: avoid to compile options if CONFIG_SECCOMP undefined
Date: Wed, 9 May 2018 07:48:46 -0500 [thread overview]
Message-ID: <c5f32951-97c5-bac7-7294-70d185abeb45@redhat.com> (raw)
In-Reply-To: <08334b5d-7bc3-befc-65af-0aae6d134e6d@linux.ibm.com>
On 05/08/2018 11:40 PM, Yi Min Zhao wrote:
>> If seccomp is disabled, we should really disable the entire -sandbox
>> argument, not merly the options to it.
> I think it would bring a lot of changes if disable the entire -sandbox
> argument.
> Looking from current code, sandbox is a default qemu option group, and
> sandbox.enable is false by default unless you obviously define it with
> true.
> So, this patch is an easier way to fixup.
If the only thing you can do with -sandbox is turn it off (which is its
default state), it's better to not advertise it at all in the first
place. I agree with Daniel that it's better to cripple -sandbox from
even being usable as a command-line argument if it isn't going to work,
as that's easier to introspect.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-05-09 12:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 3:32 [Qemu-devel] [PATCH 0/1] Bug: Sandbox: libvirt breakdowns qemu guest Yi Min Zhao
2018-05-07 3:32 ` [Qemu-devel] [PATCH 1/1] sandbox: avoid to compile options if CONFIG_SECCOMP undefined Yi Min Zhao
2018-05-07 10:31 ` Eduardo Otubo
2018-05-07 13:27 ` Yi Min Zhao
2018-05-07 18:04 ` Eric Blake
2018-05-07 22:18 ` Yi Min Zhao
2018-05-08 10:37 ` Daniel P. Berrangé
2018-05-09 4:40 ` Yi Min Zhao
2018-05-09 12:48 ` Eric Blake [this message]
2018-05-09 14:23 ` Ján Tomko
2018-05-07 9:29 ` [Qemu-devel] [PATCH 0/1] Bug: Sandbox: libvirt breakdowns qemu guest Christian Borntraeger
2018-05-07 10:33 ` Eduardo Otubo
2018-05-07 12:02 ` [Qemu-devel] [libvirt] " Ján Tomko
2018-05-07 12:12 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5f32951-97c5-bac7-7294-70d185abeb45@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zyimin@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).