qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	Bernhard Beschow <shentey@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [PATCH v3 0/7] QOM'ify PIIX southbridge creation
Date: Mon, 30 May 2022 21:45:26 +0200	[thread overview]
Message-ID: <c5fd32b5-fe22-a55b-de06-a6eac908bca2@amsat.org> (raw)
In-Reply-To: <5ef86c6c-719b-f197-3ccb-462e453dffa5@ilande.co.uk>

On 30/5/22 21:11, Mark Cave-Ayland wrote:
> On 29/05/2022 14:02, Bernhard Beschow wrote:

>>     Oh wait - I see now it's just the cover letter which is missing 
>> the additional
>>     maintainer addresses :)  If you could add them into the cover 
>> letter for your next
>>     revision that would be great, since it gives context for 
>> maintainers to help with
>>     the
>>     review process.
>>
>>
>> Hi Mark,
>>
>> Thanks for your great work you put into reviews and the useful 
>> insights! It seems to me that the time it takes for patches to be 
>> queued depends on the subsystem - some are faster, some are slower...
>>
>> I've automated my setup as described in [1]. However, it doesn't seem 
>> to work for the cover letter which I'd expect to be sent to the union 
>> of all reviewers of all patches. Any idea how to fix this?
>>
>> Best regards,
>> Bernhard
>>
>> [1] 
>> https://www.qemu.org/docs/master/devel/submitting-a-patch.html#cc-the-relevant-maintainer 
>> <https://www.qemu.org/docs/master/devel/submitting-a-patch.html#cc-the-relevant-maintainer> 
> 
> 
> Good question. I tend to do "git format-patch -o /tmp/foo 
> --cover-letter" to generate the series, fill in the cover letter, and 
> then use "git send-email /tmp/foo" to send out the emails (entering in 
> the results of get_maintainer.pl by hand). I'm not sure why the cover 
> letter isn't being generated correctly in your case I'm afraid.

Or try git-publish :) It does a first pass collecting Cc for each patch
(calling get_maintainer.pl) then use that set on the cover.

https://github.com/stefanha/git-publish


  reply	other threads:[~2022-05-30 20:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-28 19:20 [PATCH v3 0/7] QOM'ify PIIX southbridge creation Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 1/7] include/hw/southbridge/piix: Aggregate all PIIX soughbridge type names Bernhard Beschow
2022-05-29  9:05   ` Mark Cave-Ayland
2022-05-29 18:09     ` Bernhard Beschow
2022-05-30 13:19       ` Philippe Mathieu-Daudé via
2022-06-01 21:34         ` Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 2/7] hw/isa/piix4: Use object_initialize_child() for embedded struct Bernhard Beschow
2022-05-30 11:38   ` Philippe Mathieu-Daudé via
2022-06-01 21:36     ` Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 3/7] hw/isa/piix{3, 4}: Move pci_map_irq_fn's near pci_set_irq_fn's Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 4/7] hw/isa/piix{3, 4}: QOM'ify PCI device creation and wiring Bernhard Beschow
2022-05-30 13:17   ` Philippe Mathieu-Daudé via
2022-05-30 21:00     ` [PATCH v3 4/7] hw/isa/piix{3,4}: " Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 5/7] hw/isa/piix{3, 4}: Factor out ISABus retrieval from create() functions Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 6/7] hw/isa/piix4: QOM'ify PIIX4 PM creation Bernhard Beschow
2022-05-29  9:25   ` Mark Cave-Ayland
2022-05-29 18:05     ` Bernhard Beschow
2022-05-30 19:58       ` Mark Cave-Ayland
2022-06-01 21:39         ` Bernhard Beschow
2022-05-28 19:20 ` [PATCH v3 7/7] hw/isa/piix{3, 4}: Inline and remove create() functions Bernhard Beschow
2022-05-29  9:46 ` [PATCH v3 0/7] QOM'ify PIIX southbridge creation Mark Cave-Ayland
2022-05-29 10:06   ` Mark Cave-Ayland
2022-05-29 13:02     ` Bernhard Beschow
2022-05-30 19:11       ` Mark Cave-Ayland
2022-05-30 19:45         ` Philippe Mathieu-Daudé via [this message]
2022-06-04  8:36           ` Bernhard Beschow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5fd32b5-fe22-a55b-de06-a6eac908bca2@amsat.org \
    --to=qemu-devel@nongnu.org \
    --cc=f4bug@amsat.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-trivial@nongnu.org \
    --cc=shentey@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).