From: Eric Blake <eblake@redhat.com>
To: "Taylor Simpson" <tsimpson@quicinc.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "ale@rev.ng" <ale@rev.ng>,
"riku.voipio@iki.fi" <riku.voipio@iki.fi>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"laurent@vivier.eu" <laurent@vivier.eu>,
"aleksandar.m.mail@gmail.com" <aleksandar.m.mail@gmail.com>
Subject: Re: [RFC PATCH v4 00/29] Hexagon patch series
Date: Tue, 29 Sep 2020 16:28:47 -0500 [thread overview]
Message-ID: <c63a9b09-bffb-ad16-c38c-1a2b55d4ff4f@redhat.com> (raw)
In-Reply-To: <BYAPR02MB4886C114AAC9DDEF70300D23DE320@BYAPR02MB4886.namprd02.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 980 bytes --]
On 9/29/20 3:11 PM, Taylor Simpson wrote:
> Ouch! 4.8 is old enough that it doesn't support C11 _Generic which I am using. That needs at least GCC 4.9.
>
> Here are a couple of examples. As you can see, _Generic is used to dispatch to slightly different TCG generation functions depending on the type of the operands. I will scratch my head and figure out a different way to do this.
>
> #define MEM_STORE1_FUNC(X) \
> _Generic((X), int : gen_store1i, TCGv_i32 : gen_store1)
> #define MEM_STORE1(VA, DATA, SLOT) \
> MEM_STORE1_FUNC(DATA)(cpu_env, VA, DATA, ctx, SLOT)
See if you can use __builtin_choose_expr() instead. Look at
include/osdep/atomic.h which defines typeof_strip_qual() without
_Generic. linux-user/qemu.h __put_user_e() is also an example of what
appears to be a poor-man's replacement to _Generic.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-29 21:30 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 17:28 [RFC PATCH v4 00/29] Hexagon patch series Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 01/29] Hexagon Update MAINTAINERS file Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 02/29] Hexagon (target/hexagon) README Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 03/29] Hexagon (include/elf.h) ELF machine definition Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 04/29] Hexagon (target/hexagon) scalar core definition Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 05/29] Hexagon (disas) disassembler Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 06/29] Hexagon (target/hexagon) register names Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 07/29] Hexagon (target/hexagon) scalar core helpers Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 08/29] Hexagon (target/hexagon) GDB Stub Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 09/29] Hexagon (target/hexagon) architecture types Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 10/29] Hexagon (target/hexagon) instruction and packet types Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 11/29] Hexagon (target/hexagon) register fields Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 12/29] Hexagon (target/hexagon) instruction attributes Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 13/29] Hexagon (target/hexagon) instruction/packet decode Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 14/29] Hexagon (target/hexagon) instruction printing Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 15/29] Hexagon (target/hexagon) utility functions Taylor Simpson
2020-09-29 11:25 ` Philippe Mathieu-Daudé
2020-09-29 15:48 ` Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 16/29] Hexagon (target/hexagon/imported) arch import Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 17/29] Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics Taylor Simpson
2020-09-29 11:31 ` Philippe Mathieu-Daudé
2020-09-28 17:28 ` [RFC PATCH v4 18/29] Hexagon (target/hexagon) generator phase 2 - generate header files Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 19/29] Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree Taylor Simpson
2020-09-29 11:37 ` Philippe Mathieu-Daudé
2020-10-01 19:54 ` Richard Henderson
2020-10-01 23:31 ` Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 20/29] Hexagon (target/hexagon) generater phase 4 - " Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 21/29] Hexagon (target/hexagon) opcode data structures Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros Taylor Simpson
2020-09-29 12:34 ` Philippe Mathieu-Daudé
2020-09-30 21:22 ` Taylor Simpson
2020-10-01 8:53 ` Philippe Mathieu-Daudé
2020-09-28 17:28 ` [RFC PATCH v4 23/29] Hexagon (target/hexagon) instruction classes Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 24/29] Hexagon (target/hexagon) TCG generation Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 25/29] Hexagon (target/hexagon) TCG for instructions with multiple definitions Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 26/29] Hexagon (target/hexagon) translation Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 27/29] Hexagon (linux-user/hexagon) Linux user emulation Taylor Simpson
2020-09-28 21:02 ` Laurent Vivier
2020-09-30 20:47 ` Taylor Simpson
2020-10-01 7:53 ` Laurent Vivier
2020-10-01 15:40 ` Taylor Simpson
2020-10-01 18:08 ` Laurent Vivier
2020-09-28 17:28 ` [RFC PATCH v4 28/29] Hexagon (tests/tcg/hexagon) TCG tests Taylor Simpson
2020-09-28 17:28 ` [RFC PATCH v4 29/29] Hexagon build infrastructure Taylor Simpson
2020-09-29 1:12 ` [RFC PATCH v4 00/29] Hexagon patch series no-reply
2020-09-29 1:21 ` no-reply
2020-09-29 12:22 ` Philippe Mathieu-Daudé
2020-09-29 15:53 ` Taylor Simpson
2020-09-29 17:01 ` Philippe Mathieu-Daudé
2020-09-29 20:11 ` Taylor Simpson
2020-09-29 20:41 ` Philippe Mathieu-Daudé
2020-09-29 21:28 ` Eric Blake [this message]
2020-09-29 22:16 ` Taylor Simpson
2020-09-30 4:08 ` Brad Smith
2020-10-02 17:16 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c63a9b09-bffb-ad16-c38c-1a2b55d4ff4f@redhat.com \
--to=eblake@redhat.com \
--cc=ale@rev.ng \
--cc=aleksandar.m.mail@gmail.com \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).