From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org
Cc: Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 25/26] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO
Date: Fri, 26 May 2017 10:10:35 -0700 [thread overview]
Message-ID: <c643c6b9-20fb-af8f-2e2f-9a8b6e4c1159@twiddle.net> (raw)
In-Reply-To: <20170525210508.4910-26-aurelien@aurel32.net>
On 05/25/2017 02:05 PM, Aurelien Jarno wrote:
> +uint32_t HELPER(trXX)(CPUS390XState *env, uint32_t r1, uint32_t r2,
> + uint32_t sizes)
> +{
> + uintptr_t ra = GETPC();
> + int dsize = (sizes & 1) ? 1 : 2;
> + int ssize = (sizes & 2) ? 1 : 2;
> + uint16_t tst = env->regs[0] & ((1 << (8 * dsize)) - 1);
I think you should pass in tst as an argument. That way you can pass in an
out-of-band value when we implement ETF2 and test field M3 bit 3.
r~
next prev parent reply other threads:[~2017-05-26 17:10 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 21:04 [Qemu-devel] [PATCH 00/26] target/s390x: fix, improve and implement some more instructions Aurelien Jarno
2017-05-25 21:04 ` [Qemu-devel] [PATCH 01/26] target/s390x: remove dead code in translate.c Aurelien Jarno
2017-05-26 13:50 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 02/26] target/s390x: make IPTE SMP aware Aurelien Jarno
2017-05-26 13:53 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 03/26] target/s390x: implement TEST AND SET Aurelien Jarno
2017-05-26 13:42 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 04/26] target/s390x: implement TEST ADDRESSING MODE Aurelien Jarno
2017-05-26 13:44 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 05/26] target/s390x: implement PACK Aurelien Jarno
2017-05-26 13:56 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 06/26] target/s390x: implement LOAD PAIR FROM QUADWORD Aurelien Jarno
2017-05-26 14:02 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 07/26] target/s390x: implement STORE PAIR TO QUADWORD Aurelien Jarno
2017-05-26 14:07 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 08/26] target/s390x: implement MOVE INVERSE Aurelien Jarno
2017-05-26 14:10 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 09/26] target/s390x: implement MOVE NUMERICS Aurelien Jarno
2017-05-26 14:12 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 10/26] target/s390x: implement MOVE WITH OFFSET Aurelien Jarno
2017-05-26 14:16 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 11/26] target/s390x: implement MOVE ZONES Aurelien Jarno
2017-05-26 14:18 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 12/26] target/s390x: improve 24-bit and 31-bit addresses read Aurelien Jarno
2017-05-26 14:21 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 13/26] target/s390x: improve 24-bit and 31-bit addresses write Aurelien Jarno
2017-05-26 14:24 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 14/26] target/s390x: improve 24-bit and 31-bit lengths read/write Aurelien Jarno
2017-05-26 15:03 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 15/26] target/s390x: fix COMPARE LOGICAL LONG EXTENDED Aurelien Jarno
2017-05-26 15:23 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 16/26] target/s390x: implement COMPARE LOGICAL LONG Aurelien Jarno
2017-05-26 15:32 ` Richard Henderson
2017-05-29 13:00 ` Aurelien Jarno
2017-05-26 15:33 ` Richard Henderson
2017-05-25 21:04 ` [Qemu-devel] [PATCH 17/26] target/s390x: improve MOVE LONG and MOVE LONG EXTENDED Aurelien Jarno
2017-05-26 15:48 ` Richard Henderson
2017-05-25 21:05 ` [Qemu-devel] [PATCH 18/26] target/s390x: implement COMPARE LOGICAL LONG UNICODE Aurelien Jarno
2017-05-26 15:58 ` Richard Henderson
2017-05-25 21:05 ` [Qemu-devel] [PATCH 19/26] target/s390x: implement MOVE " Aurelien Jarno
2017-05-26 16:10 ` Richard Henderson
2017-05-25 21:05 ` [Qemu-devel] [PATCH 20/26] target/s390x: implement PACK ASCII Aurelien Jarno
2017-05-26 16:23 ` Richard Henderson
2017-05-25 21:05 ` [Qemu-devel] [PATCH 21/26] target/s390x: implement PACK UNICODE Aurelien Jarno
2017-05-26 16:35 ` Richard Henderson
2017-05-29 11:22 ` Aurelien Jarno
2017-05-30 16:46 ` Richard Henderson
2017-05-25 21:05 ` [Qemu-devel] [PATCH 22/26] target/s390x: implement UNPACK ASCII Aurelien Jarno
2017-05-26 16:42 ` Richard Henderson
2017-05-25 21:05 ` [Qemu-devel] [PATCH 23/26] target/s390x: implement UNPACK UNICODE Aurelien Jarno
2017-05-26 16:44 ` Richard Henderson
2017-05-25 21:05 ` [Qemu-devel] [PATCH 24/26] target/s390x: implement TEST DECIMAL Aurelien Jarno
2017-05-26 16:52 ` Richard Henderson
2017-05-25 21:05 ` [Qemu-devel] [PATCH 25/26] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO Aurelien Jarno
2017-05-26 17:10 ` Richard Henderson [this message]
2017-05-29 11:17 ` Aurelien Jarno
2017-05-30 16:45 ` Richard Henderson
2017-05-30 19:25 ` Aurelien Jarno
2017-05-30 19:42 ` Richard Henderson
2017-05-30 20:01 ` Aurelien Jarno
2017-05-25 21:05 ` [Qemu-devel] [PATCH 26/26] target/s390x: update maximum TCG model to z800 Aurelien Jarno
2017-05-29 11:31 ` Thomas Huth
2017-05-26 0:32 ` [Qemu-devel] [PATCH 27/26] target/s390x: fix adj_len_to_page Aurelien Jarno
2017-05-26 17:18 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c643c6b9-20fb-af8f-2e2f-9a8b6e4c1159@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).