From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: berrange@redhat.com, alex.bennee@linaro.org,
Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: Re: [PATCH] gitlab-ci: Use -fno-sanitize=function in the clang-user job
Date: Fri, 26 Jul 2024 11:09:04 +0200 [thread overview]
Message-ID: <c6548713-6c80-4c56-925f-de88fd18d34d@redhat.com> (raw)
In-Reply-To: <bd367b1e-1858-4344-97d9-d0ed0d1890f6@linaro.org>
On 26/07/2024 01.33, Richard Henderson wrote:
> On 7/24/24 16:08, Thomas Huth wrote:
>> On 24/07/2024 01.25, Richard Henderson wrote:
>>> With -fsanitize=undefined, which implies -fsanitize=function,
>>> clang will add a "type signature" before functions.
>>> It accesses funcptr-8 and funcptr-4 to do so.
>>>
>>> The generated TCG prologue is directly on a page boundary,
>>> so these accesses segfault.
>>>
>>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>>
>> What happend to Akihiko Odaki's more generic patch:
>>
>>
>> https://lore.kernel.org/qemu-devel/20240714-function-v1-1-cc2acb4171ba@daynix.com/
>>
>> ?
>
> This patch does not work:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/7432239478/viewer#L4956
>
> I presume this is an argument ordering issue vs --extra-cflags.
Ok, then we should definitely go with your patch to fix the job now. ... and
I just saw that you already applied it 👍
Thomas
next prev parent reply other threads:[~2024-07-26 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 23:25 [PATCH] gitlab-ci: Use -fno-sanitize=function in the clang-user job Richard Henderson
2024-07-24 6:08 ` Thomas Huth
2024-07-25 23:33 ` Richard Henderson
2024-07-26 9:09 ` Thomas Huth [this message]
2024-07-24 10:52 ` Daniel P. Berrangé
2024-07-24 22:03 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6548713-6c80-4c56-925f-de88fd18d34d@redhat.com \
--to=thuth@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).