From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/4] virtio-gpu: remove unused qdev
Date: Thu, 21 Feb 2019 18:36:45 +0100 [thread overview]
Message-ID: <c6568187-cc79-61f2-150a-07bbb5c505f7@redhat.com> (raw)
In-Reply-To: <20190221114330.17968-2-marcandre.lureau@redhat.com>
On 2/21/19 12:43 PM, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> include/hw/virtio/virtio-gpu.h | 1 -
> hw/display/virtio-gpu.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
> index c8c599f1b9..c7cb821ae3 100644
> --- a/include/hw/virtio/virtio-gpu.h
> +++ b/include/hw/virtio/virtio-gpu.h
> @@ -97,7 +97,6 @@ typedef struct VirtIOGPU {
> int enable;
>
> int config_size;
> - DeviceState *qdev;
>
> QTAILQ_HEAD(, virtio_gpu_simple_resource) reslist;
> QTAILQ_HEAD(, virtio_gpu_ctrl_command) cmdq;
> diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
> index c6fab56f9b..a52c2aed0e 100644
> --- a/hw/display/virtio-gpu.c
> +++ b/hw/display/virtio-gpu.c
> @@ -1268,7 +1268,6 @@ static void virtio_gpu_device_realize(DeviceState *qdev, Error **errp)
> QTAILQ_INIT(&g->fenceq);
>
> g->enabled_output_bitmask = 1;
> - g->qdev = qdev;
>
> for (i = 0; i < g->conf.max_outputs; i++) {
> g->scanout[i].con =
>
next prev parent reply other threads:[~2019-02-21 17:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 11:43 [Qemu-devel] [PATCH 0/4] virtio-gpu fixes (resend) Marc-André Lureau
2019-02-21 11:43 ` [Qemu-devel] [PATCH 1/4] virtio-gpu: remove unused qdev Marc-André Lureau
2019-02-21 16:46 ` Christophe Fergeau
2019-02-21 17:36 ` Philippe Mathieu-Daudé [this message]
2019-02-21 11:43 ` [Qemu-devel] [PATCH 2/4] virtio-gpu: remove unused config_size Marc-André Lureau
2019-02-21 16:51 ` Christophe Fergeau
2019-02-21 17:37 ` Philippe Mathieu-Daudé
2019-02-21 11:43 ` [Qemu-devel] [PATCH 3/4] virtio-gpu: block both 2d and 3d rendering Marc-André Lureau
2019-02-21 16:53 ` Christophe Fergeau
2019-02-21 11:43 ` [Qemu-devel] [PATCH 4/4] virtio-gpu: remove useless 'waiting' field Marc-André Lureau
2019-02-21 16:53 ` Christophe Fergeau
2019-02-21 17:38 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6568187-cc79-61f2-150a-07bbb5c505f7@redhat.com \
--to=philmd@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).