qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Collin Walling <walling@linux.ibm.com>, qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>, Alexander Graf <agraf@suse.de>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	qemu-s390x@nongnu.org, Thomas Huth <thuth@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/4] s390x/zpci: move some hotplug checks to the pre_plug handler
Date: Wed, 7 Nov 2018 20:36:30 +0100	[thread overview]
Message-ID: <c6623c2e-415b-0951-cfa6-4d83a42b81d4@redhat.com> (raw)
In-Reply-To: <723f6454-8cac-08ed-bdb6-afddc4ed7ad1@linux.ibm.com>

> 
> When did these function names drop the *_hot_plug postfix? Latest master does not reflect this change for me.
> Just figured I'd mention it now in case merging becomes a pain later ;)
> 

Mentioned it in the cover letter, part of another series
(also CC'ed to qemu-s390x@nongnu.org, so maybe easier to find for you).

>>
>>
> 
> The above concerns do not relate to any functionality of the code, so with them addressed, then:
> 
> Reviewed-by: Collin Walling <walling@linux.ibm.com>
> 

Thanks!

-- 

Thanks,

David / dhildenb

  reply	other threads:[~2018-11-07 19:37 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05 11:03 [Qemu-devel] [PATCH v1 0/4] s390x/zpci: some hotplug handler cleanups David Hildenbrand
2018-11-05 11:03 ` [Qemu-devel] [PATCH v1 1/4] s390x/zpci: drop msix.available David Hildenbrand
2018-11-05 11:19   ` Cornelia Huck
2018-11-07 16:26     ` [Qemu-devel] [qemu-s390x] " Collin Walling
2018-11-08 10:54       ` Cornelia Huck
2018-11-05 11:25   ` [Qemu-devel] " Thomas Huth
2018-11-12 17:12   ` Cornelia Huck
2018-11-05 11:03 ` [Qemu-devel] [PATCH v1 2/4] s390x/zpci: use hotplug_dev instead of looking up the host bridge David Hildenbrand
2018-11-05 11:21   ` Cornelia Huck
2018-11-05 11:37     ` David Hildenbrand
2018-11-05 11:40       ` Christian Borntraeger
2018-11-05 11:50         ` David Hildenbrand
2018-11-07 20:28           ` Collin Walling
2018-11-08 11:07             ` Cornelia Huck
2018-11-08 11:56               ` David Hildenbrand
2018-11-05 11:03 ` [Qemu-devel] [PATCH v1 3/4] s390x/zpci: move some hotplug checks to the pre_plug handler David Hildenbrand
2018-11-05 11:50   ` David Hildenbrand
2018-11-07 19:34     ` [Qemu-devel] [qemu-s390x] " Collin Walling
2018-11-07 19:36       ` David Hildenbrand [this message]
2018-11-07 19:46         ` Collin Walling
2018-11-05 11:03 ` [Qemu-devel] [PATCH v1 4/4] s390x/zpci: properly fail if the zPCI device cannot be created David Hildenbrand
2018-11-05 12:04   ` Thomas Huth
2018-11-05 12:41     ` Cornelia Huck
2018-11-05 12:46       ` David Hildenbrand
2018-11-08 11:14         ` Cornelia Huck
2018-11-07 20:15   ` Collin Walling
2018-11-08 13:35   ` Cornelia Huck
2018-11-08 13:58     ` David Hildenbrand
2018-11-12 17:14 ` [Qemu-devel] [PATCH v1 0/4] s390x/zpci: some hotplug handler cleanups Cornelia Huck
2018-11-12 17:34   ` David Hildenbrand
2018-11-13  9:03     ` Cornelia Huck
2018-11-13 12:06       ` [Qemu-devel] [qemu-s390x] " David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6623c2e-415b-0951-cfa6-4d83a42b81d4@redhat.com \
    --to=david@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    --cc=walling@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).