From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKTdN-0004Km-VK for qemu-devel@nongnu.org; Wed, 07 Nov 2018 14:37:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKTdJ-0005hU-Ka for qemu-devel@nongnu.org; Wed, 07 Nov 2018 14:37:00 -0500 References: <20181105110313.29312-1-david@redhat.com> <20181105110313.29312-4-david@redhat.com> <228ec0b2-cd30-b33b-8120-bb28e3f83e66@redhat.com> <723f6454-8cac-08ed-bdb6-afddc4ed7ad1@linux.ibm.com> From: David Hildenbrand Message-ID: Date: Wed, 7 Nov 2018 20:36:30 +0100 MIME-Version: 1.0 In-Reply-To: <723f6454-8cac-08ed-bdb6-afddc4ed7ad1@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/4] s390x/zpci: move some hotplug checks to the pre_plug handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Collin Walling , qemu-devel@nongnu.org Cc: "Michael S . Tsirkin" , Cornelia Huck , Alexander Graf , Christian Borntraeger , qemu-s390x@nongnu.org, Thomas Huth , Igor Mammedov , Richard Henderson > > When did these function names drop the *_hot_plug postfix? Latest master does not reflect this change for me. > Just figured I'd mention it now in case merging becomes a pain later ;) > Mentioned it in the cover letter, part of another series (also CC'ed to qemu-s390x@nongnu.org, so maybe easier to find for you). >> >> > > The above concerns do not relate to any functionality of the code, so with them addressed, then: > > Reviewed-by: Collin Walling > Thanks! -- Thanks, David / dhildenb