Re: [PATCH v3] hw/i386/pc_piix.c: remove unnecessary if() from pc_init1()

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 1/9/25 22:31, Mark Cave-Ayland wrote:
> Now that the isapc logic has been split out of pc_piix.c, the PCI Host Bridge
> (phb) object is now always set in pc_init1().
> 
> Since phb is now guaranteed not to be NULL, Coverity reports that the if()
> statement surrounding ioapic_init_gsi() is now unnecessary and can be removed
> along with the phb NULL initialiser.
> 
> Coverity: CID 1620557
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> Fixes: 99d0630a45 ("hw/i386/pc_piix.c: assume pcmc->pci_enabled is always true in pc_init1()")
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/i386/pc_piix.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> v3:
> - Add Coverity tag suggested by Markus and tweak commit message
>    accordingly

Queued, thanks!

(I had v2 queued with tag added but now using v3)

> 
> v2:
> - Add R-B tags from Peter and Phil
> - Remove phb NULL initialiser