From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECB38C433EF for ; Sat, 16 Oct 2021 00:02:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 540C3611C3 for ; Sat, 16 Oct 2021 00:02:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 540C3611C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:42208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbX9b-0000dW-9P for qemu-devel@archiver.kernel.org; Fri, 15 Oct 2021 20:02:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbX8h-0008FF-Da for qemu-devel@nongnu.org; Fri, 15 Oct 2021 20:01:27 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:46850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mbX8e-0004EV-W7 for qemu-devel@nongnu.org; Fri, 15 Oct 2021 20:01:27 -0400 Received: by mail-pj1-x102e.google.com with SMTP id pi19-20020a17090b1e5300b0019fdd3557d3so8417822pjb.5 for ; Fri, 15 Oct 2021 17:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7Py53g1TniXvYWUshbYzrsRdA1gpd0i/2Fr+CP9u+g0=; b=MYmvR7xCY4hj+FZpItiA09uYlH7UTg6PQSICOosKYInDBrLU1KG8Yqm5YVDvr7ZkIF KCHWHahvTcKLzc4VKTJD7Fz54J49GvVXU8dMmpeTDxIJSg/hXCZw4gNB2LlLUmP7kvY5 IBlir0TAJcqQB+MIee2a4iRYaSAfGkIuAYo8aAMxxRGEtgo30MDA3+s1PCOsEFyBqrQD Dr8zrHHV2zov/Qr52iTSSYBMGxWS6F3OedXYmKMpgLyG3YY4katTFrxsTIjGkt3ttDsk cxW8VtUkr0sjEE8oeCtz5KdznnKg+pUPc6ZZhlBL6zPMXSsO7PRp086BnzPzIZ9AjS7G TAcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7Py53g1TniXvYWUshbYzrsRdA1gpd0i/2Fr+CP9u+g0=; b=bICg/4Jx/AyAia1k2wY5FAoSHC6zOdHdpRXC7oMH3AErKi8K+fB46KzLHza/cb6nd8 muuOTxewgi4N1nQZ+lavBvS6iGWxssrOQGCOQ48HAWYyV/AogB19YwogRBaoqxl40eZm FhFnapWqHz8fKjZ/R7ZaRl8bT9OrFw7b/WyxwjauUG9ZJGD/IN5m8auMcnuE+ngOcIUZ d2zz6rZ0Eb3BgF7bmy2JRj+SrAX/WFtUHKCikxAumzmoWjDpS0cDjyA8zlgGeuaTwpvU alA00zB6ijREFyefZd+8aENLr8Go1cxPoKqE4uTvhfwMXYlwQroGW4i/srT50rBjhprd g3mg== X-Gm-Message-State: AOAM533PyXpGPxYrIDZQmZ+azPcxC7MLUsTLy/bZKB1GPh34azaE45xM IdCoVQaMfodcUMFV05NWedU6dg== X-Google-Smtp-Source: ABdhPJw1CfKCww+sUfjLh7PY/4bwutFfWVnjE827Kl0m+mqZMGh4lBBrO3gCyIYsIGXoQQCEpbxwTw== X-Received: by 2002:a17:90a:de16:: with SMTP id m22mr17145431pjv.54.1634342482996; Fri, 15 Oct 2021 17:01:22 -0700 (PDT) Received: from [192.168.1.11] ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id x7sm12039041pjl.55.2021.10.15.17.01.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Oct 2021 17:01:22 -0700 (PDT) Subject: Re: [PATCH v13 6/7] [RISCV_PM] Implement address masking functions required for RISC-V Pointer Masking extension To: Alexey Baturo References: <20211015192931.227387-1-space.monkey.delivers@gmail.com> <20211015192931.227387-7-space.monkey.delivers@gmail.com> From: Richard Henderson Message-ID: Date: Fri, 15 Oct 2021 17:01:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211015192931.227387-7-space.monkey.delivers@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-riscv@nongnu.org, sagark@eecs.berkeley.edu, kbastian@mail.uni-paderborn.de, Bin Meng , qemu-devel@nongnu.org, space.monkey.delivers@gmail.com, Alistair.Francis@wdc.com, kupokupokupopo@gmail.com, palmer@dabbelt.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/15/21 12:29 PM, Alexey Baturo wrote: > FIELD(TB_FLAGS, MSTATUS_HS_FS, 10, 2) > +/* If PointerMasking should be applied */ > +FIELD(TB_FLAGS, PM_ENABLED, 10, 1) Merge error. > + if (riscv_has_ext(env, RVJ)) { > + int priv = cpu_mmu_index(env, false) & TB_FLAGS_PRIV_MMU_MASK; cpu_mmu_index has already been computed. You want int priv = flags & TB_FLAGS_PRIV_MMU_MASK; > @@ -118,16 +125,6 @@ static void gen_nanbox_s(TCGv_i64 out, TCGv_i64 in) > tcg_gen_ori_i64(out, in, MAKE_64BIT_MASK(32, 32)); > } > > -/* > - * Temp stub: generates address adjustment for PointerMasking > - */ > -static void gen_pm_adjust_address(DisasContext *s, > - TCGv *dst, > - TCGv src) > -{ > - tcg_gen_mov_tl(*dst, src); > -} > - You might as well place the function correctly in the previous patch. Drop the silly alignment of parameters. > + int priv = cpu_mmu_index(env, false) & TB_FLAGS_PRIV_MMU_MASK; > + ctx->pm_mask = pm_mask[priv]; Using cpu_mmu_index within the translator is incorrect. You want priv = tb_flags & TB_FLAGS_PRIV_MMU_MASK; r~