From: Thomas Huth <thuth@redhat.com>
To: pannengyuan@huawei.com, lvivier@redhat.com, pbonzini@redhat.com
Cc: Euler Robot <euler.robot@huawei.com>,
zhang.zhanghailiang@huawei.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] boot-order-test: fix memleaks in boot-order-test
Date: Mon, 3 Feb 2020 07:37:53 +0100 [thread overview]
Message-ID: <c676640c-ac12-178c-8afa-010e90dff977@redhat.com> (raw)
In-Reply-To: <20200203025935.36228-1-pannengyuan@huawei.com>
On 03/02/2020 03.59, pannengyuan@huawei.com wrote:
> From: Pan Nengyuan <pannengyuan@huawei.com>
>
> It's not a big deal, but 'check qtest-ppc/ppc64' runs fail if sanitizers is enabled.
> The memory leak stack is as follow:
>
> Direct leak of 128 byte(s) in 4 object(s) allocated from:
> #0 0x7f11756f5970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970)
> #1 0x7f1174f2549d in g_malloc0 (/lib64/libglib-2.0.so.0+0x5249d)
> #2 0x556af05aa7da in mm_fw_cfg_init /mnt/sdb/qemu/tests/libqos/fw_cfg.c:119
> #3 0x556af059f4f5 in read_boot_order_pmac /mnt/sdb/qemu/tests/boot-order-test.c:137
> #4 0x556af059efe2 in test_a_boot_order /mnt/sdb/qemu/tests/boot-order-test.c:47
> #5 0x556af059f2c0 in test_boot_orders /mnt/sdb/qemu/tests/boot-order-test.c:59
> #6 0x556af059f52d in test_pmac_oldworld_boot_order /mnt/sdb/qemu/tests/boot-order-test.c:152
> #7 0x7f1174f46cb9 (/lib64/libglib-2.0.so.0+0x73cb9)
> #8 0x7f1174f46b73 (/lib64/libglib-2.0.so.0+0x73b73)
> #9 0x7f1174f46b73 (/lib64/libglib-2.0.so.0+0x73b73)
> #10 0x7f1174f46f71 in g_test_run_suite (/lib64/libglib-2.0.so.0+0x73f71)
> #11 0x7f1174f46f94 in g_test_run (/lib64/libglib-2.0.so.0+0x73f94)
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
> ---
> tests/qtest/boot-order-test.c | 6 +++---
> tests/qtest/libqos/fw_cfg.h | 2 ++
> 2 files changed, 5 insertions(+), 3 deletions(-)
Thanks, queued to my qtest-next branch:
https://gitlab.com/huth/qemu/commits/qtest-next
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2020-02-03 6:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 2:59 [PATCH] boot-order-test: fix memleaks in boot-order-test pannengyuan
2020-02-03 6:37 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c676640c-ac12-178c-8afa-010e90dff977@redhat.com \
--to=thuth@redhat.com \
--cc=euler.robot@huawei.com \
--cc=lvivier@redhat.com \
--cc=pannengyuan@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).