From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: pkrempa@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] iotests: Test internal snapshots with -blockdev
Date: Fri, 20 Sep 2019 13:44:34 +0200 [thread overview]
Message-ID: <c67ae6cf-3831-8b7e-81ee-9afbcb0c51cc@redhat.com> (raw)
In-Reply-To: <20190917110443.2029-3-kwolf@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 2095 bytes --]
On 17.09.19 13:04, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/267 | 165 ++++++++++++++++++++++++++++
> tests/qemu-iotests/267.out | 182 +++++++++++++++++++++++++++++++
> tests/qemu-iotests/common.filter | 5 +-
> tests/qemu-iotests/group | 1 +
> 4 files changed, 349 insertions(+), 4 deletions(-)
> create mode 100755 tests/qemu-iotests/267
> create mode 100644 tests/qemu-iotests/267.out
>
> diff --git a/tests/qemu-iotests/267 b/tests/qemu-iotests/267
> new file mode 100755
> index 0000000000..0d085c60a7
> --- /dev/null
> +++ b/tests/qemu-iotests/267
> @@ -0,0 +1,165 @@
> +#!/usr/bin/env bash
> +#
> +# Test which nodes are involved in internal snapshots
> +#
> +# Copyright (C) 2019 Red Hat, Inc.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
> +#
> +
> +# creator
> +owner=kwolf@redhat.com
> +
> +seq=`basename $0`
> +echo "QA output created by $seq"
> +
> +status=1 # failure is the default!
> +
> +_cleanup()
> +{
> + _cleanup_test_img
> + rm -f "$TEST_DIR/nbd"
> +}
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +# get standard environment, filters and checks
> +. ./common.rc
> +. ./common.filter
> +
> +_supported_fmt qcow2
> +_supported_proto file
> +_supported_os Linux
This needs some restriction on what refcount_bits are supported.
(because it naturally fails with refcount_bits=1)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-09-20 11:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 11:04 [Qemu-devel] [PATCH 0/2] block/snapshot: Restrict set of snapshot nodes Kevin Wolf
2019-09-17 11:04 ` [Qemu-devel] [PATCH 1/2] " Kevin Wolf
2019-09-17 13:52 ` Eric Blake
2019-09-20 16:02 ` Max Reitz
2019-09-17 11:04 ` [Qemu-devel] [PATCH 2/2] iotests: Test internal snapshots with -blockdev Kevin Wolf
2019-09-20 11:44 ` Max Reitz [this message]
2019-09-17 15:37 ` [Qemu-devel] [PATCH 0/2] block/snapshot: Restrict set of snapshot nodes Peter Krempa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c67ae6cf-3831-8b7e-81ee-9afbcb0c51cc@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).